From: Leon Romanovsky <leonro@mellanox.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Raed Salem <raeds@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Yishai Hadas <yishaih@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
linux-netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH mlx5-next v1 02/13] net/mlx5: Export flow counter related API
Date: Mon, 28 May 2018 12:16:37 +0300 [thread overview]
Message-ID: <20180528091637.GJ3085@mtr-leonro.mtl.com> (raw)
In-Reply-To: <CAJ3xEMg_2zd1yr4vZjvgEEmAAYbXX9Ax9C+Jtyt87eQNrioPVA@mail.gmail.com>
On Mon, May 28, 2018 at 11:34:18AM +0300, Or Gerlitz wrote:
> On Sun, May 27, 2018 at 1:23 PM, Leon Romanovsky <leon@kernel.org> wrote:
> > From: Raed Salem <raeds@mellanox.com>
> >
> > Exports counters API to be used in both IB and EN.
> >
> > Reviewed-by: Yishai Hadas <yishaih@mellanox.com>
> > Signed-off-by: Raed Salem <raeds@mellanox.com>
> > Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/fs_core.h | 23 ----------------------
> > .../net/ethernet/mellanox/mlx5/core/fs_counters.c | 3 +++
> > include/linux/mlx5/fs.h | 22 +++++++++++++++++++++
> > 3 files changed, 25 insertions(+), 23 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > index b6da322a8016..40992aed1791 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/fs_core.h
> > @@ -131,29 +131,6 @@ struct mlx5_flow_table {
> > struct rhltable fgs_hash;
> > };
> >
> > -struct mlx5_fc_cache {
> > - u64 packets;
> > - u64 bytes;
> > - u64 lastuse;
> > -};
> > -
> > -struct mlx5_fc {
> > - struct rb_node node;
> > - struct list_head list;
> > -
> > - /* last{packets,bytes} members are used when calculating the delta since
> > - * last reading
> > - */
> > - u64 lastpackets;
> > - u64 lastbytes;
> > -
> > - u32 id;
> > - bool deleted;
> > - bool aging;
> > -
> > - struct mlx5_fc_cache cache ____cacheline_aligned_in_smp;
> > -};
> > -
>
> are you using the caching services @ the IB driver? please point me to
> the patch that does so
IB doesn't use cache, but uses "struct mlx5_fc", which needs
mlx5_fc_cache struct for compilation.
For example in this patch [1], Raed uses "struct mlx5_fc".
[1] https://patchwork.ozlabs.org/patch/921076/
Thanks
next prev parent reply other threads:[~2018-05-28 9:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-27 10:23 [PATCH rdma-next v1 00/13] Verbs flow counters support Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 01/13] IB/uverbs: Add an ib_uobject getter to ioctl() infrastructure Leon Romanovsky
2018-05-27 10:23 ` [PATCH mlx5-next v1 02/13] net/mlx5: Export flow counter related API Leon Romanovsky
2018-05-28 8:34 ` Or Gerlitz
2018-05-28 9:16 ` Leon Romanovsky [this message]
2018-05-27 10:23 ` [PATCH rdma-next v1 03/13] IB/core: Introduce counters object and its create/destroy Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 04/13] IB/uverbs: Add create/destroy counters support Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 05/13] IB/core: Introduce counters read verb Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 06/13] IB/uverbs: Add read counters support Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 07/13] IB/core: Support passing uhw for create_flow Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 08/13] IB/core: Add support for flow counters Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 09/13] IB/uverbs: " Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 10/13] IB/mlx5: Add counters create and destroy support Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 11/13] IB/mlx5: Add flow counters binding support Leon Romanovsky
2018-05-28 17:27 ` Jason Gunthorpe
2018-05-29 7:11 ` Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 12/13] IB/mlx5: Add flow counters read support Leon Romanovsky
2018-05-27 10:23 ` [PATCH rdma-next v1 13/13] IB/mlx5: Add " Leon Romanovsky
2018-05-27 16:22 ` [PATCH rdma-next v1 00/13] Verbs flow counters support Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528091637.GJ3085@mtr-leonro.mtl.com \
--to=leonro@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=raeds@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=yishaih@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).