From: Jason Gunthorpe <jgg@ziepe.ca>
To: Greg Thelen <gthelen@google.com>
Cc: arnd@arndb.de, Doug Ledford <dledford@redhat.com>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
oleg.drokin@intel.com, andreas.dilger@intel.com,
jsimmons@infradead.org, gregkh@linuxfoundation.org,
Steve French <sfrench@samba.org>,
ericvh@gmail.com, rminnich@sandia.gov, lucho@ionkov.net,
"David S. Miller" <davem@davemloft.net>,
santosh.shilimkar@oracle.com, trond.myklebust@hammerspace.com,
anna.schumaker@netapp.com, bfields@fieldses.org,
jlayton@kernel.org, Bart Van Assche <bart.vanassche@wdc.com>,
linux-rdma@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-cifs@vger.kernel.org,
samba-techni
Subject: Re: [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies"
Date: Mon, 28 May 2018 10:39:49 -0600 [thread overview]
Message-ID: <20180528163949.GA17505@ziepe.ca> (raw)
In-Reply-To: <CAHH2K0Ysgi30gHPN8EEdDa+PfSFJLo8=6j-aq=SYy=_h6K0kPg@mail.gmail.com>
On Fri, May 25, 2018 at 05:32:52PM -0700, Greg Thelen wrote:
> On Fri, May 25, 2018 at 2:32 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> > Several subsystems depend on INFINIBAND_ADDR_TRANS, which in turn depends
> > on INFINIBAND. However, when with CONFIG_INIFIBAND=m, this leads to a
> > link error when another driver using it is built-in. The
> > INFINIBAND_ADDR_TRANS dependency is insufficient here as this is
> > a 'bool' symbol that does not force anything to be a module in turn.
>
> > fs/cifs/smbdirect.o: In function `smbd_disconnect_rdma_work':
> > smbdirect.c:(.text+0x1e4): undefined reference to `rdma_disconnect'
> > net/9p/trans_rdma.o: In function `rdma_request':
> > trans_rdma.c:(.text+0x7bc): undefined reference to `rdma_disconnect'
> > net/9p/trans_rdma.o: In function `rdma_destroy_trans':
> > trans_rdma.c:(.text+0x830): undefined reference to `ib_destroy_qp'
> > trans_rdma.c:(.text+0x858): undefined reference to `ib_dealloc_pd'
>
> > Fixes: 9533b292a7ac ("IB: remove redundant INFINIBAND kconfig
> dependencies")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Greg Thelen <gthelen@google.com>
>
> Sorry for the 9533b292a7ac problem.
> At this point the in release cycle, I think Arnd's revert is best.
>
> If there is interest, I've put a little thought into an alternative fix:
> making INFINIBAND_ADDR_TRANS tristate. But it's nontrivial.
> So I prefer this simple revert for now.
Is that a normal thing to do?
> Doug: do you need anything from me on this?
I can take the revert..
Jason
next prev parent reply other threads:[~2018-05-28 16:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-25 21:29 [PATCH] IB: Revert "remove redundant INFINIBAND kconfig dependencies" Arnd Bergmann
2018-05-25 21:38 ` Leon Romanovsky
2018-05-26 0:32 ` Greg Thelen
2018-05-28 16:39 ` Jason Gunthorpe [this message]
2018-05-28 18:02 ` Greg Thelen
2018-05-28 16:44 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180528163949.GA17505@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=andreas.dilger@intel.com \
--cc=anna.schumaker@netapp.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=bart.vanassche@wdc.com \
--cc=bfields@fieldses.org \
--cc=davem@davemloft.net \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=ericvh@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=gthelen@google.com \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=jsimmons@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
--cc=rminnich@sandia.gov \
--cc=sagi@grimberg.me \
--cc=santosh.shilimkar@oracle.com \
--cc=sfrench@samba.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).