From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Håkon Bugge" <haakon.bugge@oracle.com>
Cc: Hans Westgaard Ry <hans.westgaard.ry@oracle.com>,
jackm <jackm@dev.mellanox.co.il>,
Doug Ledford <dledford@redhat.com>,
Daniel Jurgens <danielj@mellanox.com>,
Parav Pandit <parav@mellanox.com>,
Pravin Shedge <pravin.shedge4linux@gmail.com>,
OFED mailing list <linux-rdma@vger.kernel.org>,
linux-kernel@vger.kernel.org, Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] IB/mad: Use ID allocator routines to allocate agent number
Date: Wed, 30 May 2018 16:09:34 -0600 [thread overview]
Message-ID: <20180530220934.GI30754@ziepe.ca> (raw)
In-Reply-To: <E67F0098-C2BC-49F6-AC55-3F9195712D4B@oracle.com>
On Wed, May 30, 2018 at 10:07:16PM +0200, Håkon Bugge wrote:
>
>
> > On 30 May 2018, at 17:10, Jason Gunthorpe <jgg@ziepe.ca> wrote:
> >
> > On Wed, May 30, 2018 at 02:22:56PM +0200, Hans Westgaard Ry wrote:
> >
> >> We came up with this code snippet which we think handles both preventing
> >> immediate re-use and too big/wrapping...
> >
> > Isn't this basically the same as idr_alloc_cyclic ?
>
> I draw my statement back. The idr_alloc_cyclic() is the family of idr's that associates a pointer with the bit. Hence, each bit is a bit + 64b.
>
> That's why we ended up with Hans' pseudo code.
Okay, fair enough.
Is it worth adding a ida_get_new_cyclic for this?
Jason
next prev parent reply other threads:[~2018-05-30 22:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-29 7:38 [PATCH] IB/mad: Use ID allocator routines to allocate agent number Hans Westgaard Ry
2018-05-29 8:54 ` Leon Romanovsky
2018-05-29 9:54 ` Leon Romanovsky
2018-05-30 8:18 ` jackm
2018-05-29 15:49 ` Jason Gunthorpe
2018-05-29 16:16 ` Håkon Bugge
2018-05-29 16:40 ` Jason Gunthorpe
2018-05-30 7:32 ` Håkon Bugge
2018-05-30 15:15 ` Jason Gunthorpe
2018-05-30 8:02 ` jackm
2018-05-30 12:22 ` Hans Westgaard Ry
2018-05-30 15:10 ` Jason Gunthorpe
2018-05-30 20:07 ` Håkon Bugge
2018-05-30 22:09 ` Jason Gunthorpe [this message]
2018-05-31 19:54 ` Håkon Bugge
2018-06-07 10:52 ` [PATCH v2 0/2] IB:mad " Hans Westgaard Ry
2018-06-07 10:52 ` [PATCH v2 1/2] idr: Add ida_simple_get_cyclic Hans Westgaard Ry
2018-06-07 10:52 ` [PATCH v2 2/2] IB/mad: Use ID allocator routines to allocate agent number Hans Westgaard Ry
2018-06-07 11:14 ` [PATCH v3 0/2] IB:mad " Hans Westgaard Ry
2018-06-07 11:14 ` [PATCH v3 1/2] idr: Add ida_simple_get_cyclic Hans Westgaard Ry
2018-06-07 18:50 ` Jason Gunthorpe
2018-06-07 11:14 ` [PATCH v3 2/2] IB/mad: Use ID allocator routines to allocate agent number Hans Westgaard Ry
2018-06-07 15:37 ` Matthew Wilcox
2018-06-07 17:59 ` Håkon Bugge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180530220934.GI30754@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=danielj@mellanox.com \
--cc=dledford@redhat.com \
--cc=haakon.bugge@oracle.com \
--cc=hans.westgaard.ry@oracle.com \
--cc=jackm@dev.mellanox.co.il \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=parav@mellanox.com \
--cc=pravin.shedge4linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).