From: Leon Romanovsky <leon@kernel.org> To: Michal Kubecek <mkubecek@suse.cz> Cc: Jason Gunthorpe <jgg@mellanox.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Doug Ledford <dledford@redhat.com>, Linus Torvalds <torvalds@linux-foundation.org>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [GIT PULL] Please pull RDMA subsystem changes Date: Mon, 29 Apr 2019 12:19:38 +0300 Message-ID: <20190429091938.GS6705@mtr-leonro.mtl.com> (raw) In-Reply-To: <20190429090040.GB21672@unicorn.suse.cz> On Mon, Apr 29, 2019 at 11:00:40AM +0200, Michal Kubecek wrote: > On Mon, Apr 29, 2019 at 08:40:37AM +0000, Jason Gunthorpe wrote: > > On Mon, Apr 29, 2019 at 08:09:47AM +0200, Heiko Carstens wrote: > > > On Sun, Apr 28, 2019 at 11:52:12AM +0000, Jason Gunthorpe wrote: > > > > Hi Linus, > > > > > > > > Third rc pull request > > > > > > > > Nothing particularly special here. There is a small merge conflict > > > > with Adrea's mm_still_valid patches which is resolved as below: > > > ... > > > > Jason Gunthorpe (3): > > > > RDMA/mlx5: Do not allow the user to write to the clock page > > > > RDMA/mlx5: Use rdma_user_map_io for mapping BAR pages > > > > RDMA/ucontext: Fix regression with disassociate > > > > > > This doesn't compile. The patch below would fix it, but not sure if > > > this is what is intended: > > > > > > drivers/infiniband/core/uverbs_main.c: In function 'rdma_umap_fault': > > > drivers/infiniband/core/uverbs_main.c:898:28: error: 'struct vm_fault' has no member named 'vm_start' > > > vmf->page = ZERO_PAGE(vmf->vm_start); > > > ^~ > > > diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c > > > index 7843e89235c3..65fe89b3fa2d 100644 > > > +++ b/drivers/infiniband/core/uverbs_main.c > > > @@ -895,7 +895,7 @@ static vm_fault_t rdma_umap_fault(struct vm_fault *vmf) > > > > > > /* Read only pages can just use the system zero page. */ > > > if (!(vmf->vma->vm_flags & (VM_WRITE | VM_MAYWRITE))) { > > > - vmf->page = ZERO_PAGE(vmf->vm_start); > > > + vmf->page = ZERO_PAGE(vmf->vma->vm_start); > > > get_page(vmf->page); > > > return 0; > > > } > > > > > > > Thanks Heiko, this looks right to me. > > > > I'm surprised to be seeing this at this point, these patches should > > have been seen by 0 day for several days now, and they were in > > linux-next already too.. > > Most architectures have versions of ZERO_PAGE() which ignore the > argument so that the code builds anyway. I'm not sure if 0-day also > tests s390x builds (which is where I ran into this). According to 0-build results for this patch, the answer is yes, it builds. s390 default_defconfig And it compiles uverbs_main.c (CONFIG_INFINIBAND_USER_ACCESS) kernel git:(rdma-next) grep INFIN arch/s390/configs/debug_defconfig CONFIG_INFINIBAND=m CONFIG_INFINIBAND_USER_ACCESS=m CONFIG_MLX4_INFINIBAND=m CONFIG_MLX5_INFINIBAND=m Thanks > > Michal Kubecek
next prev parent reply index Thread overview: 140+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-28 11:52 Jason Gunthorpe 2019-04-28 16:59 ` Linus Torvalds 2019-04-28 23:49 ` Jason Gunthorpe 2019-04-29 0:09 ` Linus Torvalds 2019-04-30 12:53 ` Jason Gunthorpe 2019-04-28 18:05 ` pr-tracker-bot 2019-04-29 6:09 ` Heiko Carstens 2019-04-29 8:40 ` Jason Gunthorpe 2019-04-29 9:00 ` Michal Kubecek 2019-04-29 9:19 ` Leon Romanovsky [this message] 2019-04-29 15:42 ` Doug Ledford 2019-04-29 16:29 ` Doug Ledford -- strict thread matches above, loose matches on Subject: below -- 2021-01-15 19:21 Jason Gunthorpe 2021-01-15 23:35 ` pr-tracker-bot 2020-12-16 17:57 Jason Gunthorpe 2020-12-16 21:51 ` pr-tracker-bot 2020-12-10 15:50 Jason Gunthorpe 2020-12-10 19:11 ` pr-tracker-bot 2020-11-27 14:00 Jason Gunthorpe 2020-11-27 21:21 ` pr-tracker-bot 2020-11-19 19:29 Jason Gunthorpe 2020-11-19 23:00 ` pr-tracker-bot 2020-11-05 18:16 Jason Gunthorpe 2020-11-05 20:21 ` pr-tracker-bot 2020-10-29 18:41 Jason Gunthorpe 2020-10-29 18:53 ` Linus Torvalds 2020-10-29 19:00 ` pr-tracker-bot 2020-10-16 18:51 Jason Gunthorpe 2020-10-17 18:21 ` Linus Torvalds 2020-10-17 18:42 ` Jason Gunthorpe 2020-10-17 18:22 ` pr-tracker-bot 2020-09-25 12:57 Jason Gunthorpe 2020-09-25 17:48 ` pr-tracker-bot 2020-09-10 23:38 Jason Gunthorpe 2020-09-11 18:37 ` pr-tracker-bot 2020-08-21 14:06 Jason Gunthorpe 2020-08-21 17:16 ` pr-tracker-bot 2020-08-06 18:27 Jason Gunthorpe 2020-08-07 1:55 ` pr-tracker-bot 2020-07-31 15:17 Jason Gunthorpe 2020-07-31 16:45 ` pr-tracker-bot 2020-07-24 17:47 Jason Gunthorpe 2020-07-24 21:40 ` pr-tracker-bot 2020-07-10 17:58 Jason Gunthorpe 2020-07-10 22:10 ` pr-tracker-bot 2020-06-25 17:56 Jason Gunthorpe 2020-06-25 20:15 ` pr-tracker-bot 2020-06-04 19:51 Jason Gunthorpe 2020-06-05 21:15 ` pr-tracker-bot 2020-05-29 14:15 Jason Gunthorpe 2020-05-29 21:10 ` pr-tracker-bot 2020-05-15 19:13 Jason Gunthorpe 2020-05-15 20:15 ` pr-tracker-bot 2020-04-28 19:59 Jason Gunthorpe 2020-04-28 20:40 ` pr-tracker-bot 2020-04-01 23:01 Jason Gunthorpe 2020-04-02 2:05 ` pr-tracker-bot 2020-03-26 17:31 Jason Gunthorpe 2020-03-26 17:50 ` pr-tracker-bot 2020-03-08 0:07 Jason Gunthorpe 2020-03-08 2:00 ` pr-tracker-bot 2020-02-15 21:32 Jason Gunthorpe 2020-02-16 1:20 ` pr-tracker-bot 2020-01-31 15:16 Jason Gunthorpe 2020-01-31 23:10 ` pr-tracker-bot 2020-01-10 2:16 Jason Gunthorpe 2020-01-11 14:45 ` pr-tracker-bot 2019-11-27 0:24 Jason Gunthorpe 2019-11-27 18:19 ` Linus Torvalds 2019-11-27 19:23 ` Jason Gunthorpe 2019-11-27 18:45 ` pr-tracker-bot 2019-11-14 15:16 Jason Gunthorpe 2019-11-14 16:55 ` pr-tracker-bot 2019-10-31 18:22 Jason Gunthorpe 2019-11-01 17:10 ` pr-tracker-bot 2019-10-09 14:28 Jason Gunthorpe 2019-10-09 19:30 ` pr-tracker-bot 2019-09-19 16:34 Jason Gunthorpe 2019-09-21 17:40 ` pr-tracker-bot 2019-07-30 12:15 Jason Gunthorpe 2019-07-30 20:40 ` pr-tracker-bot 2019-07-15 15:26 Jason Gunthorpe 2019-07-16 4:35 ` pr-tracker-bot 2019-06-06 20:14 Jason Gunthorpe 2019-06-07 16:45 ` pr-tracker-bot 2019-05-15 0:46 Jason Gunthorpe 2019-05-15 4:05 ` pr-tracker-bot 2019-05-09 13:37 Jason Gunthorpe 2019-05-09 16:25 ` pr-tracker-bot 2019-04-10 18:46 Jason Gunthorpe 2019-04-10 19:55 ` pr-tracker-bot 2019-03-18 1:04 Jason Gunthorpe 2019-03-19 18:15 ` pr-tracker-bot 2019-03-07 1:34 Jason Gunthorpe 2019-03-10 1:40 ` pr-tracker-bot 2019-02-21 23:07 Jason Gunthorpe 2019-02-22 18:40 ` pr-tracker-bot 2019-02-01 17:41 Jason Gunthorpe 2019-02-01 18:45 ` pr-tracker-bot 2019-01-18 3:56 Jason Gunthorpe 2019-01-18 5:35 ` pr-tracker-bot 2019-01-04 5:00 Jason Gunthorpe 2019-01-06 2:40 ` pr-tracker-bot 2018-12-24 22:16 Jason Gunthorpe 2018-12-29 1:30 ` pr-tracker-bot 2018-11-29 22:52 Jason Gunthorpe 2018-10-25 21:21 Jason Gunthorpe 2018-10-26 14:50 ` Linus Torvalds 2018-09-27 18:24 Jason Gunthorpe 2018-09-27 20:17 ` Greg Kroah-Hartman 2018-09-10 23:04 Jason Gunthorpe 2018-08-22 21:44 Jason Gunthorpe 2018-08-16 21:57 Jason Gunthorpe 2018-08-17 19:31 ` Linus Torvalds 2018-08-17 19:44 ` Linus Torvalds 2018-08-17 20:50 ` Linus Torvalds 2018-08-17 21:16 ` Jason Gunthorpe 2018-08-17 23:56 ` Linus Torvalds 2018-08-17 20:15 ` Jason Gunthorpe 2018-08-17 20:27 ` Linus Torvalds 2018-08-17 21:27 ` Jason Gunthorpe 2018-08-03 16:11 Jason Gunthorpe 2018-07-13 17:13 Jason Gunthorpe 2018-06-20 21:00 Jason Gunthorpe 2018-06-06 21:42 Jason Gunthorpe 2018-06-01 16:47 Jason Gunthorpe 2018-05-24 20:51 Jason Gunthorpe 2018-04-06 16:05 Jason Gunthorpe 2018-05-16 17:39 ` Eugene Syromiatnikov 2018-05-16 17:49 ` Jason Gunthorpe 2018-05-16 18:01 ` Eugene Syromiatnikov 2018-03-29 19:17 Jason Gunthorpe 2018-03-20 23:17 Jason Gunthorpe 2018-01-31 17:47 Jason Gunthorpe [not found] ` <20180131174735.GA18568-uk2M96/98Pc@public.gmane.org> 2018-01-31 20:11 ` Linus Torvalds [not found] ` <CA+55aFxmnW-iu1Na3QC8Ci8Q_Qdfn2Ak_9wDB6+A564R=Xn9Ag-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-01-31 21:04 ` Jason Gunthorpe [not found] ` <20180131210457.GE23352-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> 2018-02-01 19:12 ` Linus Torvalds [not found] ` <CA+55aFxySLoCHcmZgx2PiF6jEazVOSy=2idccRsWqOzmyK2gaw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2018-02-01 20:33 ` Jason Gunthorpe 2017-12-28 21:03 Jason Gunthorpe 2017-12-16 17:12 Jason Gunthorpe
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190429091938.GS6705@mtr-leonro.mtl.com \ --to=leon@kernel.org \ --cc=dledford@redhat.com \ --cc=heiko.carstens@de.ibm.com \ --cc=jgg@mellanox.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=mkubecek@suse.cz \ --cc=torvalds@linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-RDMA Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \ linux-rdma@vger.kernel.org public-inbox-index linux-rdma Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma AGPL code for this site: git clone https://public-inbox.org/public-inbox.git