From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 211AEC76192 for ; Wed, 17 Jul 2019 11:58:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E63E6205F4 for ; Wed, 17 Jul 2019 11:58:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="WsXmWAFN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726729AbfGQL6b (ORCPT ); Wed, 17 Jul 2019 07:58:31 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:43397 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbfGQL6b (ORCPT ); Wed, 17 Jul 2019 07:58:31 -0400 Received: by mail-qt1-f193.google.com with SMTP id w17so22964770qto.10 for ; Wed, 17 Jul 2019 04:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=CtIW38CyixiEAESJE2x/hR6vvP9ZY7lyz3jE6erJEA4=; b=WsXmWAFNLS9Y5gyPmjyVBufuKshUnoz9oYQO3m2Kyy2wMtQLDRqxhz084Ma4sggKxA VrwuLzOtiAy8rszSQKzE18fvnWZV7M1q7YnEAmJigLzdicTLpZGoNiZ3Gar/CFdANUGQ +gt0fDflhj1oNluiZIVGuibWAh1JTcQepAsHP/YRP7PCiQsEbkufbX49wfrYCtAj9p/q ZpOMd9vVDGljJ+MPyoKgDKJFbWpQx34cZ14/YkYB9E0gHWhEQolXuspRkMtBiWOO9Km7 Ew1EzqQInlJf4dxI+ivorIznpDm2P9V/p9lWf5oiX205bEqIkGxkVFU6X6xClAOP44Zp QzPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=CtIW38CyixiEAESJE2x/hR6vvP9ZY7lyz3jE6erJEA4=; b=tPwwq+Mfw18N6V4g4axbQDMFkkuUJ3O5i2gA6T423KicXdOStCj6iO+TY81c1jyZGN WJKJQT4by2ifoSUhEUXuKbhfOw9rdjzEMFbJfB84rdfCgY5bbZ4nzaoB952dzQvF8TZU 5nJUZFPZ7oGdNrODp2DYDDA1+YAb7dV4bU5wrGFO45eVzVCP6nD1/linlK+Z9S8WZJJN FVcVXFjgUhEYU+YVojPGWmXT3hT/IKrhwvSZ7ZpqT/Xeo+6TfY5Fks1Wx+P3uXzEHBkV 3troxWrcPcptxx0euCNUFl0FrVx8P83wkEraCKQaA//IOKeMvLxYU+LcZv9p0LSQB5Y3 AHtQ== X-Gm-Message-State: APjAAAWY+Ff8B2IDfsMicoZE6FfdLB1qzYCEujQbkZC5f7eHdGJpn+tG 3CQmE9DZ+ry6p5c+kfMOn6sq2FxLuRJCDA== X-Google-Smtp-Source: APXvYqx+j7x9Tmvjx0AtdL0JLRa2IEARVY42fsMnhsZXPsgl7xwQHvLdp4tWEgHcwSJhOki+ORlGpQ== X-Received: by 2002:ac8:394b:: with SMTP id t11mr26922427qtb.286.1563364709720; Wed, 17 Jul 2019 04:58:29 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id n18sm10459998qtr.28.2019.07.17.04.58.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 17 Jul 2019 04:58:29 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hniZo-0003Vz-Og; Wed, 17 Jul 2019 08:58:28 -0300 Date: Wed, 17 Jul 2019 08:58:28 -0300 From: Jason Gunthorpe To: Andrey Konovalov Cc: Linux ARM , Linux Memory Management List , LKML , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, kvm@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" , Vincenzo Frascino , Will Deacon , Mark Rutland , Andrew Morton , Greg Kroah-Hartman , Kees Cook , Yishai Hadas , Felix Kuehling , Alexander Deucher , Christian Koenig , Mauro Carvalho Chehab , Jens Wiklander , Alex Williamson , Leon Romanovsky , Luc Van Oostenryck , Dave Martin , Khalid Aziz , enh , Christoph Hellwig , Dmitry Vyukov , Kostya Serebryany , Evgeniy Stepanov , Lee Smith , Ramana Radhakrishnan , Jacob Bramley , Ruben Ayrapetyan , Robin Murphy , Kevin Brodsky , Szabolcs Nagy , Catalin Marinas Subject: Re: [PATCH v18 11/15] IB/mlx4: untag user pointers in mlx4_get_umem_mr Message-ID: <20190717115828.GE12119@ziepe.ca> References: <20190624174015.GL29120@arrakis.emea.arm.com> <20190715180510.GC4970@ziepe.ca> <20190716120624.GA29727@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Jul 17, 2019 at 01:44:07PM +0200, Andrey Konovalov wrote: > On Tue, Jul 16, 2019 at 2:06 PM Jason Gunthorpe wrote: > > > > On Tue, Jul 16, 2019 at 12:42:07PM +0200, Andrey Konovalov wrote: > > > On Mon, Jul 15, 2019 at 8:05 PM Jason Gunthorpe wrote: > > > > > > > > On Mon, Jul 15, 2019 at 06:01:29PM +0200, Andrey Konovalov wrote: > > > > > On Mon, Jun 24, 2019 at 7:40 PM Catalin Marinas wrote: > > > > > > > > > > > > On Mon, Jun 24, 2019 at 04:32:56PM +0200, Andrey Konovalov wrote: > > > > > > > This patch is a part of a series that extends kernel ABI to allow to pass > > > > > > > tagged user pointers (with the top byte set to something else other than > > > > > > > 0x00) as syscall arguments. > > > > > > > > > > > > > > mlx4_get_umem_mr() uses provided user pointers for vma lookups, which can > > > > > > > only by done with untagged pointers. > > > > > > > > > > > > > > Untag user pointers in this function. > > > > > > > > > > > > > > Signed-off-by: Andrey Konovalov > > > > > > > drivers/infiniband/hw/mlx4/mr.c | 7 ++++--- > > > > > > > 1 file changed, 4 insertions(+), 3 deletions(-) > > > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > > > > > This patch also needs an ack from the infiniband maintainers (Jason). > > > > > > > > > > Hi Jason, > > > > > > > > > > Could you take a look and give your acked-by? > > > > > > > > Oh, I think I did this a long time ago. Still looks OK. > > > > > > Hm, maybe that was we who lost it. Thanks! > > > > > > > You will send it? > > > > > > I will resend the patchset once the merge window is closed, if that's > > > what you mean. > > > > No.. I mean who send it to Linus's tree? ie do you want me to take > > this patch into rdma? > > I think the plan was to merge the whole series through the mm tree. > But I don't mind if you want to take this patch into your tree. It's > just that this patch doesn't make much sense without the rest of the > series. Generally I prefer if subsystem changes stay in subsystem trees. If the patch is good standalone, and the untag API has already been merged, this is a better strategy. Jason