From: Jason Gunthorpe <jgg@mellanox.com>
To: Doug Ledford <dledford@redhat.com>
Cc: Leon Romanovsky <leon@kernel.org>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH rdma-rc] RDMA/mlx5: Release locks during notifier unregister
Date: Thu, 1 Aug 2019 16:43:34 +0000 [thread overview]
Message-ID: <20190801164330.GH23885@mellanox.com> (raw)
In-Reply-To: <b74a9eb67af54e8f5050e97a3ab13899de17fe0a.camel@redhat.com>
On Thu, Aug 01, 2019 at 12:40:43PM -0400, Doug Ledford wrote:
> > It does have a lock though, the caller holds it, hence the request for
> > the lockdep.
>
> You're right, although I think the lockdep annotation can be a separate
> patch as it's neeeded on more than just the function this patch touches.
Why? This relies on that lock, so it should have the
lockdep_assert_held assert.
If there are more functions with implicit locking theyt they can be
fixed separately...
Jason
next prev parent reply other threads:[~2019-08-01 16:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 8:38 [PATCH rdma-rc] RDMA/mlx5: Release locks during notifier unregister Leon Romanovsky
2019-07-31 16:22 ` Doug Ledford
2019-07-31 17:00 ` Jason Gunthorpe
2019-07-31 17:09 ` Leon Romanovsky
2019-07-31 17:22 ` Jason Gunthorpe
2019-07-31 18:01 ` Leon Romanovsky
2019-07-31 18:51 ` Doug Ledford
2019-08-01 8:22 ` Leon Romanovsky
2019-07-31 19:55 ` Jason Gunthorpe
2019-08-01 8:27 ` Leon Romanovsky
2019-08-01 12:00 ` Jason Gunthorpe
2019-08-01 12:08 ` Leon Romanovsky
2019-08-01 14:16 ` Doug Ledford
2019-08-01 15:59 ` Leon Romanovsky
2019-08-01 16:11 ` Doug Ledford
2019-08-01 16:20 ` Jason Gunthorpe
2019-08-01 16:40 ` Doug Ledford
2019-08-01 16:43 ` Jason Gunthorpe [this message]
2019-08-01 16:50 ` Doug Ledford
2019-08-01 17:31 ` Leon Romanovsky
2019-08-01 16:23 ` Leon Romanovsky
2019-08-01 16:42 ` Doug Ledford
2019-08-01 17:33 ` Leon Romanovsky
2019-08-01 20:09 ` Doug Ledford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190801164330.GH23885@mellanox.com \
--to=jgg@mellanox.com \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).