From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73F28C32751 for ; Wed, 7 Aug 2019 12:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3F21621E6A for ; Wed, 7 Aug 2019 12:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565180021; bh=UMTWpUND0WCduYIX9IaBA5Cr2IkOsNeVVZuz7zrRtlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zN3kKx5BgPKQ62FHX0ZRNSQJbvXQefBNrH6HEj4xm1gI2vaoEexHHObgJBk8OTC2e XNmnrn3X2DbYubDDlk+oEeChR/q5lTvUAQZPSIxc7r//5ZCOrBEeSERi1gQ3qjynN0 tf/wFr0qWsQKygVK/OhMVNg6bt0gwJBhxBJ/jLxc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387476AbfHGMNk (ORCPT ); Wed, 7 Aug 2019 08:13:40 -0400 Received: from mail.kernel.org ([198.145.29.99]:39820 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387446AbfHGMNk (ORCPT ); Wed, 7 Aug 2019 08:13:40 -0400 Received: from localhost (unknown [77.137.115.125]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3CE1D21BF2; Wed, 7 Aug 2019 12:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1565180019; bh=UMTWpUND0WCduYIX9IaBA5Cr2IkOsNeVVZuz7zrRtlY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PLGEhfz6txgseM61MXgKczSPAvxvqk/eGyHU1HFHOAY3xwiTvzv8oRFktY/0+BTLy NzZAUkQ7GKNZc5Nw6MXlRJyCrnpk6WGsbi8xXrl3x0xVEzbr3duZOrrZZxInmP1hmw K9q9ZKIauBPJ7ol9z3a/3zzGQGNrrHHSYQzybli0= Date: Wed, 7 Aug 2019 15:13:35 +0300 From: Leon Romanovsky To: Jason Gunthorpe Cc: Doug Ledford , RDMA mailing list , Erez Alfasi Subject: Re: [PATCH rdma-next 2/6] RDMA/umem: Add ODP type indicator within ib_umem_odp Message-ID: <20190807121335.GC32366@mtr-leonro.mtl.com> References: <20190807103403.8102-1-leon@kernel.org> <20190807103403.8102-3-leon@kernel.org> <20190807114406.GC1571@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190807114406.GC1571@mellanox.com> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Aug 07, 2019 at 11:44:16AM +0000, Jason Gunthorpe wrote: > On Wed, Aug 07, 2019 at 01:33:59PM +0300, Leon Romanovsky wrote: > > From: Erez Alfasi > > > > ODP type can be divided into 2 subclasses: > > Explicit and Implicit ODP. > > > > Adding a type enums and an odp type flag within > > ib_umem_odp will give us an indication whether a > > given MR is ODP implicit/explicit registered. > > > > Signed-off-by: Erez Alfasi > > Signed-off-by: Leon Romanovsky > > --- > > drivers/infiniband/core/umem.c | 1 + > > include/rdma/ib_umem_odp.h | 14 ++++++++++++++ > > include/uapi/rdma/ib_user_verbs.h | 5 +++++ > > 3 files changed, 20 insertions(+) > > No for this patch, I've got a series cleaning up this > implicit/explicit nonsense, and the result is much cleaner than this. It doesn't really clean anything, just stores implicit/explicit information. > > This series will have to wait. The information exposed in this series is already available in uverbs, so whatever cleanup will come, we still need to expose ODP MR type. This patch is tiny part of whole series, why should we block whole series and iproute2? Thanks > > Jason