Re: [PATCH for-next V4 0/4] RDMA: Cleanups and improvements

[Jason Gunthorpe <jgg@ziepe.ca>]

On Thu, Aug 08, 2019 at 04:38:19PM -0400, Doug Ledford wrote:
> On Thu, 2019-08-08 at 10:54 +0300, Leon Romanovsky wrote:
> > On Wed, Aug 07, 2019 at 03:56:26PM -0400, Doug Ledford wrote:
> > > On Wed, 2019-08-07 at 13:31 +0300, Kamal Heib wrote:
> > > > This series includes few cleanups and improvements, the first
> > > > patch
> > > > introduce a new enum for describing the physical state values and
> > > > use
> > > > it
> > > > instead of using the magic numbers, patch 2-4 add support for a
> > > > common
> > > > query port for iWARP drivers and remove the common code from the
> > > > iWARP
> > > > drivers.
> > > > 
> > > > Changes from v3:
> > > > - Patch #1:
> > > > 
> > > > Changes from v2:
> > > > - Patch #1:
> > > > - Patch #3:
> > > > 
> > > > Changes from v1 :
> > > > - Patch #3:
> > > > 
> > > > Kamal Heib (4):
> > > >   RDMA: Introduce ib_port_phys_state enum
> > > >   RDMA/cxgb3: Use ib_device_set_netdev()
> > > >   RDMA/core: Add common iWARP query port
> > > >   RDMA/{cxgb3, cxgb4, i40iw}: Remove common code
> > > 
> > > Thanks, series applied to for-next.
> > 
> > Doug,
> > 
> > First patch is not accurate and need to be reworked/discussed.
> > 
> > first, it changed "Phy Test" output to be "PhyTest" and second
> > "<unknown>" was changed to be "Unknown". I don't think that it is a
> > big
> > deal, but who knows what will break after this change.
> 
> A quick grep -r of rdma-core for "Phy Test" and "unknown" says nothing
> will break, but that doesn't attest to anything else.
> 
> It is also still in my wip branch, so can be fixed directly if needed.

There is no reason to change the text so we should fix it

Jason