From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7B91CC433FF for ; Mon, 12 Aug 2019 12:28:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A84F21744 for ; Mon, 12 Aug 2019 12:28:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="hj/Fuo5y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728517AbfHLM2Q (ORCPT ); Mon, 12 Aug 2019 08:28:16 -0400 Received: from mail-qk1-f194.google.com ([209.85.222.194]:37069 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728412AbfHLM2Q (ORCPT ); Mon, 12 Aug 2019 08:28:16 -0400 Received: by mail-qk1-f194.google.com with SMTP id s14so6310419qkm.4 for ; Mon, 12 Aug 2019 05:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=F3NVoBe9n1v2ZfRa55FdnUViyntY9dM8fBRiLu0L+fw=; b=hj/Fuo5ytWHe0SJ+13jcDdQMsbU/i1ZIACgIViMzJiw64MJCvg0Xb2wHJG7iO+F4CY aU/8Q4e5EoRTDQDpyyngxGAd8VRdCivVvM9K4kJH8VkohD0SyifJp3mGzN0GcVbvBsA6 4Y51i7Ejn6Y8PGCOwhEemjauQp1RbvuAk+XvQ3vNiR6Z8yE71AQmuSIriJA5+G1/cPmw b9Fve7MbxQYSmPLxPc8WFWQFK9ggMft0bP6KTFKqQIAdoHpT+phxWGWiOfnw0VACG5Ib rBDe3YqIH8M46+Mj9gTd05nIVBhQ30Y1/5SkXNdMnFNsQXrdNcqB8yDxa3rqTHlr6dLq iK8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=F3NVoBe9n1v2ZfRa55FdnUViyntY9dM8fBRiLu0L+fw=; b=WjApuKoCM7hGiH/N0hAGQ2Y7VK3FW31TW6DKmmsIX/osrp5ckEVpmqrn4FlGM+dtIU G18eO5qaCtp3zsXP6PA6nfE1n8npkSLj0YFZu1AG82SA1EQgb+aArO//uHsHci9UhEFH 41xa4RK34uaRHASU7/ItXttxbUVki+SCIXa0Sg8R3mBzSdk1AeDVzYm5HzM8R5eN6gec BghW3DcDnNQixE8OPjnSdWCOKzCoC1sJy7j+iXudbfQ9mI0Js6iEo15Tfac+tFa5TA9W /tNfC4Zl8qFbV4qDTWFBOTUCQ4rbluTee9HTry9lnJzTJaR4TBHRyewyUgM8wwxbp9Iu vnEA== X-Gm-Message-State: APjAAAW9QMbO3WdTRlFYb5zlZwqbT+9dOo3ZzEAzTiwdRAfNkFG3tLnR xS95K+QYND6H/bkR8wvOGsKZ8A== X-Google-Smtp-Source: APXvYqwODBrrpXeLg1uZt60+w4xuw/RA5y0XlK9HIDJS76yjPxmVou6ZmWwl4OVp2Tm+2EwyPKY3dw== X-Received: by 2002:a05:620a:12d2:: with SMTP id e18mr29712440qkl.176.1565612895187; Mon, 12 Aug 2019 05:28:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-55-100.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.55.100]) by smtp.gmail.com with ESMTPSA id z2sm9588656qtq.7.2019.08.12.05.28.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 12 Aug 2019 05:28:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1hx9Qs-00079D-9F; Mon, 12 Aug 2019 09:28:14 -0300 Date: Mon, 12 Aug 2019 09:28:14 -0300 From: Jason Gunthorpe To: ira.weiny@intel.com Cc: Andrew Morton , Dan Williams , Matthew Wilcox , Jan Kara , Theodore Ts'o , John Hubbard , Michal Hocko , Dave Chinner , linux-xfs@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nvdimm@lists.01.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: Re: [RFC PATCH v2 15/19] mm/gup: Introduce vaddr_pin_pages() Message-ID: <20190812122814.GC24457@ziepe.ca> References: <20190809225833.6657-1-ira.weiny@intel.com> <20190809225833.6657-16-ira.weiny@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190809225833.6657-16-ira.weiny@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Aug 09, 2019 at 03:58:29PM -0700, ira.weiny@intel.com wrote: > From: Ira Weiny > > The addition of FOLL_LONGTERM has taken on additional meaning for CMA > pages. > > In addition subsystems such as RDMA require new information to be passed > to the GUP interface to track file owning information. As such a simple > FOLL_LONGTERM flag is no longer sufficient for these users to pin pages. > > Introduce a new GUP like call which takes the newly introduced vaddr_pin > information. Failure to pass the vaddr_pin object back to a vaddr_put* > call will result in a failure if pins were created on files during the > pin operation. Is this a 'vaddr' in the traditional sense, ie does it work with something returned by valloc? Maybe another name would be better? I also wish GUP like functions took in a 'void __user *' instead of the unsigned long to make this clear :\ Jason