From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Wenwen Wang <wenwen@cs.uga.edu>
Cc: Tariq Toukan <tariqt@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org (open list:MELLANOX ETHERNET DRIVER
(mlx4_en)),
linux-rdma@vger.kernel.org (open list:MELLANOX MLX4 core VPI
driver), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH v2] net/mlx4_en: fix a memory leak bug
Date: Tue, 13 Aug 2019 19:46:25 -0700 [thread overview]
Message-ID: <20190813194625.565e02b8@cakuba.netronome.com> (raw)
In-Reply-To: <1565637095-7972-1-git-send-email-wenwen@cs.uga.edu>
On Mon, 12 Aug 2019 14:11:35 -0500, Wenwen Wang wrote:
> In mlx4_en_config_rss_steer(), 'rss_map->indir_qp' is allocated through
> kzalloc(). After that, mlx4_qp_alloc() is invoked to configure RSS
> indirection. However, if mlx4_qp_alloc() fails, the allocated
> 'rss_map->indir_qp' is not deallocated, leading to a memory leak bug.
>
> To fix the above issue, add the 'qp_alloc_err' label to free
> 'rss_map->indir_qp'.
>
> Fixes: 4931c6ef04b4 ("net/mlx4_en: Optimized single ring steering")
> Signed-off-by: Wenwen Wang <wenwen@cs.uga.edu>
Applied, thanks.
prev parent reply other threads:[~2019-08-14 2:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 19:11 [PATCH v2] net/mlx4_en: fix a memory leak bug Wenwen Wang
2019-08-13 14:39 ` Tariq Toukan
2019-08-14 2:46 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190813194625.565e02b8@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
--cc=wenwen@cs.uga.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).