From: David Miller <davem@davemloft.net>
To: yanjun.zhu@oracle.com
Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
gerd.rausch@oracle.com
Subject: Re: [PATCHv2 1/1] net: rds: add service level support in rds-info
Date: Sat, 24 Aug 2019 16:58:51 -0700 (PDT) [thread overview]
Message-ID: <20190824.165851.1817456673626840850.davem@davemloft.net> (raw)
In-Reply-To: <1566608656-30836-1-git-send-email-yanjun.zhu@oracle.com>
From: Zhu Yanjun <yanjun.zhu@oracle.com>
Date: Fri, 23 Aug 2019 21:04:16 -0400
> diff --git a/include/uapi/linux/rds.h b/include/uapi/linux/rds.h
> index fd6b5f6..cba368e 100644
> --- a/include/uapi/linux/rds.h
> +++ b/include/uapi/linux/rds.h
> @@ -250,6 +250,7 @@ struct rds_info_rdma_connection {
> __u32 rdma_mr_max;
> __u32 rdma_mr_size;
> __u8 tos;
> + __u8 sl;
> __u32 cache_allocs;
> };
I'm applying this, but I am once again severely disappointed in how
RDS development is being handled.
From the Fixes: commit:
Since rds.h in rds-tools is not related with the kernel rds.h,
the change in kernel rds.h does not affect rds-tools.
This is the height of arrogance and shows a lack of understanding of
what user ABI requirements are all about.
It is possible for other userland components to be built by other
people, outside of your controlled eco-system and tools, that use
these interfaces.
And you cannot control that.
Therefore you cannot make arbitrary changes to UABI data strucures
just because the tool you use and maintain is not effected by it.
Please stop making these incredibly incompatible user interface
changes in the RDS stack.
I am, from this point forward, going to be extra strict on RDS stack
changes especially in this area.
next prev parent reply other threads:[~2019-08-24 23:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-24 1:04 [PATCHv2 1/1] net: rds: add service level support in rds-info Zhu Yanjun
2019-08-24 1:25 ` santosh.shilimkar
2019-08-24 1:36 ` Zhu Yanjun
2019-08-24 23:58 ` David Miller [this message]
2019-08-25 14:11 ` Zhu Yanjun
2019-09-03 1:58 ` Gustavo A. R. Silva
2019-09-04 5:08 ` Zhu Yanjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190824.165851.1817456673626840850.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=gerd.rausch@oracle.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=yanjun.zhu@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).