linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Doug Ledford <dledford@redhat.com>
Cc: Chuck Lever <chuck.lever@oracle.com>,
	Michal Kalderon <Michal.Kalderon@cavium.com>,
	linux-rdma <linux-rdma@vger.kernel.org>
Subject: Re: qedr memory leak report
Date: Sat, 31 Aug 2019 18:19:45 +0300	[thread overview]
Message-ID: <20190831151945.GJ12611@unreal> (raw)
In-Reply-To: <63286035eb752429fdb651750acf74765caecfe5.camel@redhat.com>

On Sat, Aug 31, 2019 at 10:33:13AM -0400, Doug Ledford wrote:
> On Sat, 2019-08-31 at 10:30 +0300, Leon Romanovsky wrote:
> > Doug,
> >
> > I think that it can be counted as good example why allowing memory
> > leaks
> > in drivers (HNS) is not so great idea.
>
> Crashing the machine is worse.

The problem with it that you are "punishing" whole subsystem
because of some piece of crap which anyway users can't buy.
If HNS wants to have memory leaks, they need to do it outside
of upstream kernel.

In general, if users buy shitty hardware, they need to be ready
to have kernel panics too. It works with faulty DRAM where kernel
doesn't hide such failures, so don't see any rationale to invent
something special for ib_device.

Thanks

  reply	other threads:[~2019-08-31 15:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-30 18:03 qedr memory leak report Chuck Lever
2019-08-30 18:27 ` Chuck Lever
2019-08-31  7:30   ` Leon Romanovsky
2019-08-31 14:33     ` Doug Ledford
2019-08-31 15:19       ` Leon Romanovsky [this message]
2019-08-31 17:17         ` Doug Ledford
2019-08-31 18:55           ` Leon Romanovsky
2019-09-02  7:53   ` [EXT] " Michal Kalderon
2019-09-03 12:53     ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190831151945.GJ12611@unreal \
    --to=leon@kernel.org \
    --cc=Michal.Kalderon@cavium.com \
    --cc=chuck.lever@oracle.com \
    --cc=dledford@redhat.com \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).