* [PATCH] RDMA/cma: fix false error message
@ 2019-09-02 9:27 Håkon Bugge
2019-09-12 13:25 ` Jason Gunthorpe
0 siblings, 1 reply; 2+ messages in thread
From: Håkon Bugge @ 2019-09-02 9:27 UTC (permalink / raw)
To: Doug Ledford, Jason Gunthorpe; +Cc: linux-rdma, linux-kernel, Håkon Bugge
In addr_handler(), assuming status == 0 and the device already has
been acquired (id_priv->cma_dev != NULL), we get the following
incorrect "error" message:
RDMA CM: ADDR_ERROR: failed to resolve IP. status 0
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
drivers/infiniband/core/cma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index 19f1730a4f24..c7985c24f914 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -3046,7 +3046,7 @@ static void addr_handler(int status, struct sockaddr *src_addr,
if (status)
pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to acquire device. status %d\n",
status);
- } else {
+ } else if (status) {
pr_debug_ratelimited("RDMA CM: ADDR_ERROR: failed to resolve IP. status %d\n", status);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] RDMA/cma: fix false error message
2019-09-02 9:27 [PATCH] RDMA/cma: fix false error message Håkon Bugge
@ 2019-09-12 13:25 ` Jason Gunthorpe
0 siblings, 0 replies; 2+ messages in thread
From: Jason Gunthorpe @ 2019-09-12 13:25 UTC (permalink / raw)
To: Håkon Bugge; +Cc: Doug Ledford, linux-rdma, linux-kernel
On Mon, Sep 02, 2019 at 11:27:31AM +0200, Håkon Bugge wrote:
> In addr_handler(), assuming status == 0 and the device already has
> been acquired (id_priv->cma_dev != NULL), we get the following
> incorrect "error" message:
>
> RDMA CM: ADDR_ERROR: failed to resolve IP. status 0
>
> Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
I added a fixes line, please don't forget
Applied to for-next
Thanks,
Jason
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-12 13:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-02 9:27 [PATCH] RDMA/cma: fix false error message Håkon Bugge
2019-09-12 13:25 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).