From: David Miller <davem@davemloft.net>
To: colin.king@canonical.com
Cc: tariqt@mellanox.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller
Date: Tue, 10 Sep 2019 10:29:36 +0200 (CEST) [thread overview]
Message-ID: <20190910.102936.1648930911852673896.davem@davemloft.net> (raw)
In-Reply-To: <20190906115348.16621-1-colin.king@canonical.com>
From: Colin King <colin.king@canonical.com>
Date: Fri, 6 Sep 2019 12:53:48 +0100
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate the array modes on the stack but instead make it
> static const. Makes the object code smaller by 303 bytes.
>
> Before:
> text data bss dec hex filename
> 51240 5008 1312 57560 e0d8 mellanox/mlx4/en_ethtool.o
>
> After:
> text data bss dec hex filename
> 50937 5008 1312 57257 dfa9 mellanox/mlx4/en_ethtool.o
>
> (gcc version 9.2.1, amd64)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Applied to net-next.
prev parent reply other threads:[~2019-09-10 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-06 11:53 [PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller Colin King
2019-09-10 8:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910.102936.1648930911852673896.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).