From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0E44C3A5A2 for ; Tue, 10 Sep 2019 08:29:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B2CCD208E4 for ; Tue, 10 Sep 2019 08:29:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727342AbfIJI3j (ORCPT ); Tue, 10 Sep 2019 04:29:39 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:53184 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727058AbfIJI3j (ORCPT ); Tue, 10 Sep 2019 04:29:39 -0400 Received: from localhost (unknown [148.69.85.38]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D8EB9154B29E5; Tue, 10 Sep 2019 01:29:37 -0700 (PDT) Date: Tue, 10 Sep 2019 10:29:36 +0200 (CEST) Message-Id: <20190910.102936.1648930911852673896.davem@davemloft.net> To: colin.king@canonical.com Cc: tariqt@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx4_en: ethtool: make array modes static const, makes object smaller From: David Miller In-Reply-To: <20190906115348.16621-1-colin.king@canonical.com> References: <20190906115348.16621-1-colin.king@canonical.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 10 Sep 2019 01:29:39 -0700 (PDT) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Colin King Date: Fri, 6 Sep 2019 12:53:48 +0100 > From: Colin Ian King > > Don't populate the array modes on the stack but instead make it > static const. Makes the object code smaller by 303 bytes. > > Before: > text data bss dec hex filename > 51240 5008 1312 57560 e0d8 mellanox/mlx4/en_ethtool.o > > After: > text data bss dec hex filename > 50937 5008 1312 57257 dfa9 mellanox/mlx4/en_ethtool.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Applied to net-next.