From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18062C49ED9 for ; Tue, 10 Sep 2019 22:21:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB6E32168B for ; Tue, 10 Sep 2019 22:21:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="r99ohcwK" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725957AbfIJWVg (ORCPT ); Tue, 10 Sep 2019 18:21:36 -0400 Received: from mail-io1-f66.google.com ([209.85.166.66]:38990 "EHLO mail-io1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725916AbfIJWVg (ORCPT ); Tue, 10 Sep 2019 18:21:36 -0400 Received: by mail-io1-f66.google.com with SMTP id d25so41337689iob.6; Tue, 10 Sep 2019 15:21:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=zNmBqBiKCk6tuEuyxER70RAEgALJreQQf3E9yiwzkPY=; b=r99ohcwKO6on8GYUYhTUw3dsqLewE0ODeVEZotLOrqQA43sN7r9DokEoVlVL1HCflz ZrIQGgVoQcHuQjS3o+DIz8ULnED9bDJELls0lDm+ApttHrAtHexW5gXonlKkxaTu18rz SLQF7oTk9o9ikcFExf8wrtkOUbv//fzps+EprldpFg1fbUuhCjsNR0nfeORSB5iWpXxf XVCtKWJwvHzdq2H2hkAwLtN+ymRgQqjyl7kVFf6lD0cnbgvRyhxgwAQR00kMjF3PCw1A TYrtAiW1IrrYvOX3/4drPB6XRbAQdn9rV4a4zDeYJIJa9RXQFBmOwQTCNLG5vEQa4SlE 9c1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=zNmBqBiKCk6tuEuyxER70RAEgALJreQQf3E9yiwzkPY=; b=qRX7svBTsuJ1SFd4FGKV2qTxfBQRYAsbR64quTcgDDiCL8Xu4ApnIOmgjFV/SgDVox LBCrEc+t2Iyb2K5yrAHSawTyG8d8c70S79t1eZpheUaYknn1J3FjObbzAGhdYPRwaj8c xx6xCzdwmqAAOttEyFMDyIVhgHtuGjpBU2F3huPgbferXy1cCdrUnSSFGfY3hsVUd5Yq A2VFIhh5NAvlEuXnm+mS42v1somCwJqGnKKm4WS/FtVV/DtraY4/H0AUR5CWfZypS0th WM8soELSbzhkq7ZVWpLCWw1+EQ6GJtX+nxwbiSxDAe0FBjgrXAwrcRtxBCPblsLxcPuh xhtg== X-Gm-Message-State: APjAAAV+lgsMHXpok2X1WSfWv2Kk2pyoG2bVbwM2pfhVRCK8creOqvLm oaZoMI5cPL9TRJL0wmICHtU= X-Google-Smtp-Source: APXvYqzGodRMVSnOXMqK629VGLR8xwRkydp5Rwp2qc2P+lInChSSTK3xgA3CoFbTTSOw3XXP+BnoSQ== X-Received: by 2002:a02:7113:: with SMTP id n19mr33640058jac.82.1568154095088; Tue, 10 Sep 2019 15:21:35 -0700 (PDT) Received: from cs-dulles.cs.umn.edu (cs-dulles.cs.umn.edu. [128.101.35.54]) by smtp.googlemail.com with ESMTPSA id u6sm14814127iop.18.2019.09.10.15.21.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Sep 2019 15:21:34 -0700 (PDT) From: Navid Emamdoost Cc: emamd001@umn.edu, smccaman@umn.edu, kjlu@umn.edu, Navid Emamdoost , Selvin Xavier , Devesh Sharma , Somnath Kotur , Sriharsha Basavapatna , Doug Ledford , Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] RDMA: fix goto target to release the allocated memory Date: Tue, 10 Sep 2019 17:21:19 -0500 Message-Id: <20190910222120.16517-1-navid.emamdoost@gmail.com> X-Mailer: git-send-email 2.17.1 To: unlisted-recipients:; (no To-header on input) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org In bnxt_re_create_srq, when ib_copy_to_udata fails allocated memory should be released by goto fail. Signed-off-by: Navid Emamdoost --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index 098ab883733e..4a91ffe2c676 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1398,7 +1398,7 @@ int bnxt_re_create_srq(struct ib_srq *ib_srq, dev_err(rdev_to_dev(rdev), "SRQ copy to udata failed!"); bnxt_qplib_destroy_srq(&rdev->qplib_res, &srq->qplib_srq); - goto exit; + goto fail; } } if (nq) -- 2.17.1