From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Saleem, Shiraz" <shiraz.saleem@intel.com>
Cc: Leon Romanovsky <leon@kernel.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"jgg@mellanox.com" <jgg@mellanox.com>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions
Date: Fri, 27 Sep 2019 20:23:46 +0200 [thread overview]
Message-ID: <20190927182346.GE1804168@kroah.com> (raw)
In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7AC704647@fmsmsx123.amr.corp.intel.com>
On Fri, Sep 27, 2019 at 02:28:20PM +0000, Saleem, Shiraz wrote:
> > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions
> >
> > On Thu, Sep 26, 2019 at 07:49:33PM +0000, Saleem, Shiraz wrote:
> > > > Subject: Re: [RFC 15/20] RDMA/irdma: Add miscellaneous utility
> > > > definitions
> > > >
> > > > On Thu, Sep 26, 2019 at 09:45:14AM -0700, Jeff Kirsher wrote:
> > > > > From: Mustafa Ismail <mustafa.ismail@intel.com>
> > > > >
> > > > > Add miscellaneous utility functions and headers.
> > > > >
> > > > > Signed-off-by: Mustafa Ismail <mustafa.ismail@intel.com>
> > > > > Signed-off-by: Shiraz Saleem <shiraz.saleem@intel.com>
> > > > > ---
> > > > > drivers/infiniband/hw/irdma/osdep.h | 108 ++
> > > > > drivers/infiniband/hw/irdma/protos.h | 96 ++
> > > > > drivers/infiniband/hw/irdma/status.h | 70 +
> > > > > drivers/infiniband/hw/irdma/utils.c | 2333
> > > > > ++++++++++++++++++++++++++
> > > > > 4 files changed, 2607 insertions(+) create mode 100644
> > > > > drivers/infiniband/hw/irdma/osdep.h
> > > > > create mode 100644 drivers/infiniband/hw/irdma/protos.h
> > > > > create mode 100644 drivers/infiniband/hw/irdma/status.h
> > > > > create mode 100644 drivers/infiniband/hw/irdma/utils.c
> > > > >
> > > > > diff --git a/drivers/infiniband/hw/irdma/osdep.h
> > > > > b/drivers/infiniband/hw/irdma/osdep.h
> > > > > new file mode 100644
> > > > > index 000000000000..5885b6fa413d
> > > > > --- /dev/null
> > > > > +++ b/drivers/infiniband/hw/irdma/osdep.h
> > > > > @@ -0,0 +1,108 @@
> > > > > +/* SPDX-License-Identifier: GPL-2.0 or Linux-OpenIB */
> > > > > +/* Copyright (c) 2019, Intel Corporation. */
> > > > > +
> > > > > +#ifndef IRDMA_OSDEP_H
> > > > > +#define IRDMA_OSDEP_H
> > > > > +
> > > > > +#include <linux/version.h>
> > > > > +#include <linux/kernel.h>
> > > > > +#include <linux/vmalloc.h>
> > > > > +#include <linux/string.h>
> > > > > +#include <linux/bitops.h>
> > > > > +#include <linux/pci.h>
> > > > > +#include <net/tcp.h>
> > > > > +#include <crypto/hash.h>
> > > > > +/* get readq/writeq support for 32 bit kernels, use the low-first
> > > > > +version */ #include <linux/io-64-nonatomic-lo-hi.h>
> > > > > +
> > > > > +#define MAKEMASK(m, s) ((m) << (s))
> > > >
> > > > It is a little bit over-macro.
> > > >
> > >
> > > Why is this a problem?
> > > We are not translating any basic kernel construct here.
> >
> > See BIT() definition.
> >
> OK. And?
And you just re-created GENMASK(). Please use in-kernel definitions
instead of creating your own.
thanks,
greg k-h
next prev parent reply other threads:[~2019-09-27 18:24 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 16:44 [RFC 00/20] Intel RDMA/IDC Driver series Jeff Kirsher
2019-09-26 16:45 ` [RFC 01/20] ice: Initialize and register multi-function device to provide RDMA Jeff Kirsher
2019-09-26 18:05 ` Greg KH
2019-09-26 23:39 ` Nguyen, Anthony L
2019-09-27 5:13 ` gregkh
2019-09-27 18:03 ` Ertman, David M
2019-10-23 17:44 ` Jason Gunthorpe
2019-10-23 17:55 ` Ertman, David M
2019-10-23 18:01 ` Jason Gunthorpe
2019-10-24 18:56 ` gregkh
2019-10-24 19:10 ` Jason Gunthorpe
2019-10-24 22:25 ` Ertman, David M
2019-10-25 1:30 ` gregkh
2019-10-25 22:27 ` Ertman, David M
2019-10-26 18:53 ` gregkh
2019-10-31 7:42 ` Tomas Winkler
2019-09-26 16:45 ` [RFC 02/20] ice: Implement peer communications Jeff Kirsher
2019-09-26 16:45 ` [RFC 03/20] i40e: Register multi-function device to provide RDMA Jeff Kirsher
2019-09-26 16:45 ` [RFC 04/20] RDMA/irdma: Add driver framework definitions Jeff Kirsher
2019-09-26 16:55 ` Jason Gunthorpe
2019-09-26 18:02 ` gregkh
2019-09-26 18:04 ` Jason Gunthorpe
2019-09-26 18:10 ` Saleem, Shiraz
2019-09-26 17:30 ` Leon Romanovsky
2019-09-26 19:51 ` Saleem, Shiraz
2019-10-04 20:12 ` Jeff Kirsher
2019-10-04 23:45 ` Jason Gunthorpe
2019-10-05 0:46 ` Jeff Kirsher
2019-10-05 6:28 ` Leon Romanovsky
2019-10-05 7:08 ` gregkh
2019-10-05 22:01 ` Jason Gunthorpe
2019-09-26 16:45 ` [RFC 05/20] RDMA/irdma: Implement device initialization definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 06/20] RDMA/irdma: Implement HW Admin Queue OPs Jeff Kirsher
2019-09-26 16:45 ` [RFC 07/20] RDMA/irdma: Add HMC backing store setup functions Jeff Kirsher
2019-09-26 16:45 ` [RFC 08/20] RDMA/irdma: Add privileged UDA queue implementation Jeff Kirsher
2019-09-26 16:45 ` [RFC 09/20] RDMA/irdma: Add QoS definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 10/20] RDMA/irdma: Add connection manager Jeff Kirsher
2019-09-26 16:45 ` [RFC 11/20] RDMA/irdma: Add PBLE resource manager Jeff Kirsher
2019-09-26 16:45 ` [RFC 12/20] RDMA/irdma: Implement device supported verb APIs Jeff Kirsher
2019-09-26 17:37 ` Leon Romanovsky
2019-09-26 17:40 ` Jason Gunthorpe
2019-09-26 19:50 ` Saleem, Shiraz
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-27 4:50 ` Leon Romanovsky
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-28 6:00 ` Leon Romanovsky
2019-09-30 14:14 ` Saleem, Shiraz
2019-09-26 16:45 ` [RFC 13/20] RDMA/irdma: Add RoCEv2 UD OP support Jeff Kirsher
2019-09-26 16:45 ` [RFC 14/20] RDMA/irdma: Add user/kernel shared libraries Jeff Kirsher
2019-09-26 16:45 ` [RFC 15/20] RDMA/irdma: Add miscellaneous utility definitions Jeff Kirsher
2019-09-26 17:49 ` Leon Romanovsky
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-27 4:46 ` Leon Romanovsky
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-27 18:23 ` gregkh [this message]
2019-09-28 5:53 ` Leon Romanovsky
2019-09-26 16:45 ` [RFC 16/20] RDMA/irdma: Add dynamic tracing for CM Jeff Kirsher
2019-09-26 16:45 ` [RFC 17/20] RDMA/irdma: Add ABI definitions Jeff Kirsher
2019-09-26 16:45 ` [RFC 18/20] RDMA/irdma: Update MAINTAINERS file Jeff Kirsher
2019-09-26 16:45 ` [RFC 19/20] RDMA/irdma: Add Kconfig and Makefile Jeff Kirsher
2019-09-26 16:45 ` [RFC 20/20] RDMA/i40iw: Mark i40iw as deprecated Jeff Kirsher
2019-09-26 17:40 ` Leon Romanovsky
2019-09-26 19:49 ` Saleem, Shiraz
2019-09-26 19:55 ` gregkh
2019-09-27 14:28 ` Saleem, Shiraz
2019-09-27 20:18 ` Doug Ledford
2019-09-27 20:17 ` Doug Ledford
2019-09-28 5:55 ` Leon Romanovsky
2019-10-02 21:15 ` Dennis Dalessandro
2019-10-03 8:23 ` Leon Romanovsky
2019-09-29 9:28 ` [RFC 00/20] Intel RDMA/IDC Driver series Or Gerlitz
2019-09-30 15:46 ` Jeff Kirsher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190927182346.GE1804168@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=dledford@redhat.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jgg@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shiraz.saleem@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).