From: Stefan Metzmacher <metze@samba.org>
To: linux-rdma@vger.kernel.org
Cc: Stefan Metzmacher <metze@samba.org>
Subject: [PATCH] rdma/core: add __module_get()/module_put() to cma_[de]ref_dev()
Date: Mon, 30 Sep 2019 11:04:55 +0200 [thread overview]
Message-ID: <20190930090455.10772-1-metze@samba.org> (raw)
Currently there seems to be a problem when an RDMA listener or connection
is active on an ib_device.
'rmmod rdma_rxe' (the same for 'siw' and most likely all
others) just hangs like this until shutdown the listeners and
connections:
[<0>] remove_client_context+0x97/0xe0 [ib_core]
[<0>] disable_device+0x90/0x120 [ib_core]
[<0>] __ib_unregister_device+0x41/0xa0 [ib_core]
[<0>] ib_unregister_driver+0xbb/0x100 [ib_core]
[<0>] rxe_module_exit+0x1a/0x8aa [rdma_rxe]
[<0>] __x64_sys_delete_module+0x147/0x290
[<0>] do_syscall_64+0x5a/0x130
[<0>] entry_SYSCALL_64_after_hwframe+0x44/0xa9
The following would be expected:
rmmod: ERROR: Module rdma_rxe is in use
And this change provides that.
Once all add listeners and connections are gone
the module can be removed again.
Signed-off-by: Stefan Metzmacher <metze@samba.org>
Cc: stable@vger.kernel.org
---
drivers/infiniband/core/cma.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index a68d0ccf67a4..d10f3d01fa02 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -276,6 +276,7 @@ enum {
void cma_ref_dev(struct cma_device *cma_dev)
{
atomic_inc(&cma_dev->refcount);
+ __module_get(cma_dev->device->ops.owner);
}
struct cma_device *cma_enum_devices_by_ibdev(cma_device_filter filter,
@@ -512,6 +513,7 @@ static void cma_attach_to_dev(struct rdma_id_private *id_priv,
void cma_deref_dev(struct cma_device *cma_dev)
{
+ module_put(cma_dev->device->ops.owner);
if (atomic_dec_and_test(&cma_dev->refcount))
complete(&cma_dev->comp);
}
--
2.17.1
next reply other threads:[~2019-09-30 9:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:04 Stefan Metzmacher [this message]
2019-09-30 12:41 ` [PATCH] rdma/core: add __module_get()/module_put() to cma_[de]ref_dev() Jason Gunthorpe
2019-09-30 13:52 ` Stefan Metzmacher
2019-10-01 14:45 ` Jason Gunthorpe
2019-10-01 22:03 ` Stefan Metzmacher
2019-10-02 0:57 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190930090455.10772-1-metze@samba.org \
--to=metze@samba.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).