From: Jason Gunthorpe <jgg@ziepe.ca>
To: Weihang Li <liweihang@hisilicon.com>
Cc: "dledford@redhat.com" <dledford@redhat.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH for-next] RDMA/hns: Add UD support for hip08
Date: Fri, 4 Oct 2019 14:35:32 -0300 [thread overview]
Message-ID: <20191004173531.GC13988@ziepe.ca> (raw)
In-Reply-To: <cff5e5f3-8eac-4456-0b4e-5d5bb9c9b393@hisilicon.com>
On Fri, Oct 04, 2019 at 10:13:00AM +0800, Weihang Li wrote:
> > diff --git a/drivers/infiniband/hw/hns/hns_roce_qp.c b/drivers/infiniband/hw/hns/hns_roce_qp.c
> > index ba81768..5374cd0 100644
> > +++ b/drivers/infiniband/hw/hns/hns_roce_qp.c
> > @@ -377,6 +377,10 @@ static int hns_roce_set_user_sq_size(struct hns_roce_dev *hr_dev,
> > hr_qp->sge.sge_cnt = roundup_pow_of_two(hr_qp->sq.wqe_cnt *
> > (hr_qp->sq.max_gs - 2));
> >
> > + if (hr_qp->ibqp.qp_type == IB_QPT_UD)
> > + hr_qp->sge.sge_cnt = roundup_pow_of_two(hr_qp->sq.wqe_cnt *
> > + hr_qp->sq.max_gs);
> > +
> > if ((hr_qp->sq.max_gs > 2) && (hr_dev->pci_dev->revision == 0x20)) {
> > if (hr_qp->sge.sge_cnt > hr_dev->caps.max_extend_sg) {
> > dev_err(hr_dev->dev,
> > @@ -1005,6 +1009,7 @@ struct ib_qp *hns_roce_create_qp(struct ib_pd *pd,
> > int ret;
> >
> > switch (init_attr->qp_type) {
> > + case IB_QPT_UD:
> > case IB_QPT_RC: {
> > hr_qp = kzalloc(sizeof(*hr_qp), GFP_KERNEL);
> > if (!hr_qp)
> >
>
> Hi Jason & Leon,
>
> Do you have some suggestions on this patch? Could it be applied to for-next?
I'm not applying any more hns patches for features until the security
issue is settled
Jason
prev parent reply other threads:[~2019-10-04 17:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 8:50 [PATCH for-next] RDMA/hns: Add UD support for hip08 Weihang Li
2019-10-04 2:13 ` Weihang Li
2019-10-04 17:35 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004173531.GC13988@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).