From: Jason Gunthorpe <jgg@ziepe.ca>
To: Leon Romanovsky <leon@kernel.org>
Cc: Doug Ledford <dledford@redhat.com>,
Mohamad Heib <mohamadh@mellanox.com>,
RDMA mailing list <linux-rdma@vger.kernel.org>,
Erez Alfasi <ereza@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>
Subject: Re: [PATCH rdma-rc] IB/core: Fix wrong iterating on ports
Date: Fri, 4 Oct 2019 15:52:38 -0300 [thread overview]
Message-ID: <20191004185238.GA13770@ziepe.ca> (raw)
In-Reply-To: <20191002122127.17571-1-leon@kernel.org>
On Wed, Oct 02, 2019 at 03:21:27PM +0300, Leon Romanovsky wrote:
> From: Mohamad Heib <mohamadh@mellanox.com>
>
> rdma_for_each_port is already incrementing the iterator's value
> it receives therefore, after the first iteration the iterator is
> increased by 2 which eventually causing wrong queries
> and possible traces.
>
> Fix the above by removing the old redundant incrementation that
> was used before rdma_for_each_port() macro.
>
> Fixes: ea1075edcbab ("RDMA: Add and use rdma_for_each_port")
> Signed-off-by: Mohamad Heib <mohamadh@mellanox.com>
> Reviewed-by: Erez Alfasi <ereza@mellanox.com>
> Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
> ---
> drivers/infiniband/core/security.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-rc, thanks
Jason
prev parent reply other threads:[~2019-10-04 18:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-02 12:21 [PATCH rdma-rc] IB/core: Fix wrong iterating on ports Leon Romanovsky
2019-10-04 18:52 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004185238.GA13770@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=ereza@mellanox.com \
--cc=leon@kernel.org \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mohamadh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).