From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9099FC47404 for ; Mon, 7 Oct 2019 15:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6361520700 for ; Mon, 7 Oct 2019 15:57:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570463839; bh=0BpLEdWJdcI8c4BrPNiOWB3KtNgijzyJF8MPFyT7NBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=hHN+V517vF4qiA47vnTJ73q5QgOZJfZocOYw44mcwYdXQ7WwKwgd2wdHOXHfK6GTX ESJCsTcrJ5/MhXHJb/Z4l82rZ6DWo0C6mwrkyt9ZTItEuJtwh0uh0x7Tl8OLDFkC6s /bmmrThaF9qwFjhlcR/ZxlDeIMvIn8EUoa6O+yW0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727975AbfJGP5S (ORCPT ); Mon, 7 Oct 2019 11:57:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:54712 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727791AbfJGP5S (ORCPT ); Mon, 7 Oct 2019 11:57:18 -0400 Received: from localhost (unknown [77.137.89.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3B2142067B; Mon, 7 Oct 2019 15:57:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570463838; bh=0BpLEdWJdcI8c4BrPNiOWB3KtNgijzyJF8MPFyT7NBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ivvbeu5rWN6RD0z0thho71E9UQELpg0FVV5u54/qwN+kaVI3iTrkWz0LVn0hNjylm ETIMkPxb9XVqZlXZgwTa6w7lU+k1ycFuJgL6I6Y0KeMMMTbNTMckB6Q0ScTZPnmhEK 5EBbsTK0GOqtf8INx84t+EwwW3izh7GczVsv2/SQ= Date: Mon, 7 Oct 2019 18:57:14 +0300 From: Leon Romanovsky To: Christoph Hellwig Cc: Doug Ledford , Jason Gunthorpe , RDMA mailing list , Or Gerlitz , Yamin Friedman , Saeed Mahameed , linux-netdev Subject: Re: [PATCH rdma-next v2 2/3] RDMA/rw: Support threshold for registration vs scattering to local pages Message-ID: <20191007155714.GZ5855@unreal> References: <20191007135933.12483-1-leon@kernel.org> <20191007135933.12483-3-leon@kernel.org> <20191007150041.GA3702@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191007150041.GA3702@infradead.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Mon, Oct 07, 2019 at 08:00:41AM -0700, Christoph Hellwig wrote: > > */ > > + > > static inline bool rdma_rw_io_needs_mr(struct ib_device *dev, u8 port_num, > > Same like an empty line sneaked in here. Except for that the whole > series looks fine: > > Reviewed-by: Christoph Hellwig Thanks