Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH for-rc] RDMA/qedr: Fix reported firmware version
@ 2019-10-07 21:07 Kamal Heib
  2019-10-10  8:46 ` [EXT] " Michal Kalderon
  0 siblings, 1 reply; 2+ messages in thread
From: Kamal Heib @ 2019-10-07 21:07 UTC (permalink / raw)
  To: linux-rdma
  Cc: Doug Ledford, Jason Gunthorpe, Michal Kalderon, Ariel Elior, Kamal Heib

Remove spaces from the reported firmware version string.
Actual value:
$ cat /sys/class/infiniband/qedr0/fw_ver
8. 37. 7. 0

Expected value:
$ cat /sys/class/infiniband/qedr0/fw_ver
8.37.7.0

Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init")
Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
---
 drivers/infiniband/hw/qedr/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/qedr/main.c b/drivers/infiniband/hw/qedr/main.c
index 5136b835e1ba..dc71b6e16a07 100644
--- a/drivers/infiniband/hw/qedr/main.c
+++ b/drivers/infiniband/hw/qedr/main.c
@@ -76,7 +76,7 @@ static void qedr_get_dev_fw_str(struct ib_device *ibdev, char *str)
 	struct qedr_dev *qedr = get_qedr_dev(ibdev);
 	u32 fw_ver = (u32)qedr->attr.fw_ver;
 
-	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d. %d. %d. %d",
+	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d.%d.%d.%d",
 		 (fw_ver >> 24) & 0xFF, (fw_ver >> 16) & 0xFF,
 		 (fw_ver >> 8) & 0xFF, fw_ver & 0xFF);
 }
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [EXT] [PATCH for-rc] RDMA/qedr: Fix reported firmware version
  2019-10-07 21:07 [PATCH for-rc] RDMA/qedr: Fix reported firmware version Kamal Heib
@ 2019-10-10  8:46 ` " Michal Kalderon
  0 siblings, 0 replies; 2+ messages in thread
From: Michal Kalderon @ 2019-10-10  8:46 UTC (permalink / raw)
  To: Kamal Heib, linux-rdma; +Cc: Doug Ledford, Jason Gunthorpe, Ariel Elior

> From: Kamal Heib <kamalheib1@gmail.com>
> Sent: Tuesday, October 8, 2019 12:08 AM
> 
> External Email
> 
> ----------------------------------------------------------------------
> Remove spaces from the reported firmware version string.
> Actual value:
> $ cat /sys/class/infiniband/qedr0/fw_ver
> 8. 37. 7. 0
> 
> Expected value:
> $ cat /sys/class/infiniband/qedr0/fw_ver
> 8.37.7.0
> 
> Fixes: ec72fce401c6 ("qedr: Add support for RoCE HW init")
> Signed-off-by: Kamal Heib <kamalheib1@gmail.com>
> ---
>  drivers/infiniband/hw/qedr/main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/qedr/main.c
> b/drivers/infiniband/hw/qedr/main.c
> index 5136b835e1ba..dc71b6e16a07 100644
> --- a/drivers/infiniband/hw/qedr/main.c
> +++ b/drivers/infiniband/hw/qedr/main.c
> @@ -76,7 +76,7 @@ static void qedr_get_dev_fw_str(struct ib_device
> *ibdev, char *str)
>  	struct qedr_dev *qedr = get_qedr_dev(ibdev);
>  	u32 fw_ver = (u32)qedr->attr.fw_ver;
> 
> -	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d. %d. %d. %d",
> +	snprintf(str, IB_FW_VERSION_NAME_MAX, "%d.%d.%d.%d",
>  		 (fw_ver >> 24) & 0xFF, (fw_ver >> 16) & 0xFF,
>  		 (fw_ver >> 8) & 0xFF, fw_ver & 0xFF);  }
> --
> 2.20.1

Thanks, 

Acked-by: Michal Kalderon <michal.kalderon@marvell.com>



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-07 21:07 [PATCH for-rc] RDMA/qedr: Fix reported firmware version Kamal Heib
2019-10-10  8:46 ` [EXT] " Michal Kalderon

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org linux-rdma@archiver.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/ public-inbox