From: Leon Romanovsky <leon@kernel.org>
To: Don Dutile <ddutile@redhat.com>
Cc: Potnuri Bharat Teja <bharat@chelsio.com>,
jgg@ziepe.ca, dledford@redhat.com, linux-rdma@vger.kernel.org,
nirranjan@chelsio.com
Subject: Re: [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel.
Date: Thu, 17 Oct 2019 09:06:47 +0300 [thread overview]
Message-ID: <20191017060647.GG6957@unreal> (raw)
In-Reply-To: <411c4ea1-4320-fa04-b014-7e5fe91869a8@redhat.com>
On Wed, Oct 16, 2019 at 01:47:29PM -0400, Don Dutile wrote:
> On 09/30/2019 03:42 AM, Potnuri Bharat Teja wrote:
<...>
> > -
> > -#endif /* CXGB3_ABI_USER_H */
> > diff --git a/include/uapi/rdma/rdma_user_ioctl_cmds.h b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > index b8bb285f6b2a..b2680051047a 100644
> > --- a/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > +++ b/include/uapi/rdma/rdma_user_ioctl_cmds.h
> > @@ -88,7 +88,6 @@ enum rdma_driver_id {
> > RDMA_DRIVER_UNKNOWN,
> > RDMA_DRIVER_MLX5,
> > RDMA_DRIVER_MLX4,
> > - RDMA_DRIVER_CXGB3,
> > RDMA_DRIVER_CXGB4,
> > RDMA_DRIVER_MTHCA,
> > RDMA_DRIVER_BNXT_RE,
> >
> Isn't there a better way to mark a driver deprecated?
Change in this enum was a mistake.
>
> This kind of removal makes long-term maintenance of such drivers painful in downstream distros, as API changes that are rippled from core through all the drivers, don't update these drivers, and when backporting such API changes to downstream distros, we have to +1 removed drivers.
https://lore.kernel.org/linux-rdma/20191015075419.18185-2-leon@kernel.org/T/#u
>
> It's much easier if upstream continues to update the drivers for such across-the-driver-patch-changes.
> heck, add a separate patch that punches out a printk stating DEPRECATED (dropping a patch to backport is easy! :) ).
>
> I told Doug I'd shoot him if he removed another driver from upstream again, that still has to be maintained in RHEL -- don't make me take him *and Jason* out! ;-) ... yeah, you too Jason!
>
>
>
>
>
next prev parent reply other threads:[~2019-10-17 6:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 7:42 [PATCH for-next] iw_cxgb3: remove iw_cxgb3 module from kernel Potnuri Bharat Teja
2019-10-04 18:11 ` Jason Gunthorpe
2019-10-17 6:41 ` Adit Ranadive
2019-10-17 8:29 ` Potnuri Bharat Teja
2019-10-18 20:47 ` Jason Gunthorpe
2019-10-18 20:49 ` Doug Ledford
2019-10-10 14:26 ` Michal Kalderon
2019-10-16 17:47 ` Don Dutile
2019-10-17 6:06 ` Leon Romanovsky [this message]
2019-10-18 20:46 ` Jason Gunthorpe
2019-10-18 20:51 ` Doug Ledford
2019-10-18 22:50 ` Don Dutile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017060647.GG6957@unreal \
--to=leon@kernel.org \
--cc=bharat@chelsio.com \
--cc=ddutile@redhat.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
--cc=nirranjan@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).