From: Honggang LI <honli@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: dledford@redhat.com, jgg@ziepe.ca, linux-rdma@vger.kernel.org
Subject: Re: [linux-next patch] RDMA/srp: add module parameter 'has_max_it_iu_size'
Date: Tue, 29 Oct 2019 14:47:27 +0800 [thread overview]
Message-ID: <20191029064727.GA22221@dhcp-128-227.nay.redhat.com> (raw)
In-Reply-To: <e797397c-3bfb-610a-bcf1-9cfdfc75c680@acm.org>
On Fri, Oct 25, 2019 at 07:10:44PM -0700, Bart Van Assche wrote:
> On 2019-10-25 06:23, Honggang LI wrote:
> > +module_param(has_max_it_iu_size, bool, 0444);
> > +MODULE_PARM_DESC(has_max_it_iu_size,
> > + "Indicate the module supports max_it_iu_size login parameter");
>
> Since the approach of this patch requires to add one new kernel
> parameter every time a new login parameter is added, I don't think this
> approach is future-proof. Has it been considered to export a list of all
> supported login parameters to user space?
ok, I will drop this patch and usespace v2 srp_daemon patch.
thanks
prev parent reply other threads:[~2019-10-29 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 13:23 [linux-next patch] RDMA/srp: add module parameter 'has_max_it_iu_size' Honggang LI
2019-10-26 2:10 ` Bart Van Assche
2019-10-29 6:47 ` Honggang LI [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029064727.GA22221@dhcp-128-227.nay.redhat.com \
--to=honli@redhat.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).