From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E541CA9EC4 for ; Tue, 29 Oct 2019 19:52:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 115B72086A for ; Tue, 29 Oct 2019 19:52:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="farqsGSi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726695AbfJ2TwQ (ORCPT ); Tue, 29 Oct 2019 15:52:16 -0400 Received: from mail-qt1-f194.google.com ([209.85.160.194]:43348 "EHLO mail-qt1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726530AbfJ2TwQ (ORCPT ); Tue, 29 Oct 2019 15:52:16 -0400 Received: by mail-qt1-f194.google.com with SMTP id c26so3422215qtj.10 for ; Tue, 29 Oct 2019 12:52:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=etY+CBhDEUwzAdor1k/bGcw3XJJ1m/Kp3y65R3dEiKM=; b=farqsGSisMFfToV5/jjl1jtlqaSaWVnx0Dkc1EINYpyGLuTn8XU7M1DVa63vG7qSSe NHF/BYHgnkG09TnrjKfQl89ViAKy8yfJSLoUmQCDVpVBYDEGM9hUd/+J1DeOist5yEtH wYJZqreDuTHrg4dryu3x+k+f2uXuZCoe7QOgCcP4zKLVKJb/Tgf4t043zuSCmywaFK8c hg65jqY8BKSkkuezxXM3W0c80Lk+t7DMbsJ6h/tc1xs9OADPs11wzPpDlFu9n+J8kipX GwkWbbLUmGDzkmcQI1/2GlGg3/yMuFCGlhccJhfJ0vY6EVMqbgHdPd37YCVXLk9+RCvY tipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=etY+CBhDEUwzAdor1k/bGcw3XJJ1m/Kp3y65R3dEiKM=; b=c3HWnyfA0nk8q9TYFoYcCvv/8Nx8yZuljSMFTcUtTg80+N578oGWz/c+ygJ2pH0vUy 0/RLmw9Wk0qFguKanHf/DYQ7QDeN7309j+xSkL27SvGvIhEhlCiIdRQEDWhU3xPiEFSF 3LuJaVvrBw6Xis+xRw0t4ToBiAi1cgObOvBNXEx/2YtA+tJ5FsTVtfOm5TI+6EkbXeCe Y/LFQ/03+U5WUkhjCVudAaupl8Fc39qUlpp/ZzhbhskVKiO+UnLXInKFZBbeq0FnOIZE 4EVqpPPnR4Ss7uANXRgnoPE2Dea1wG3jm66Ksl941LxOyFeWBI3Bzt7CDhd63W8qYQ3J S/Og== X-Gm-Message-State: APjAAAVRRvPpIIPaa+z+edZ3i0aYiIeE1Jy/6ywAcoelMRZ3a7y4CQVE 4Nre93GklOeU4cXd5SEKDV0FyQ== X-Google-Smtp-Source: APXvYqxCYJgqGvmvouxwJHd0bRUeKLMfivNA75lKFRTkDA36hMn3sldqw9mK3gXzdCg1ydVYXI6u5g== X-Received: by 2002:ad4:52c8:: with SMTP id p8mr11346512qvs.114.1572378735270; Tue, 29 Oct 2019 12:52:15 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-162-113-180.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.162.113.180]) by smtp.gmail.com with ESMTPSA id u11sm6973420qtg.11.2019.10.29.12.52.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 29 Oct 2019 12:52:14 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iPXXK-0000Tg-35; Tue, 29 Oct 2019 16:52:14 -0300 Date: Tue, 29 Oct 2019 16:52:14 -0300 From: Jason Gunthorpe To: Dennis Dalessandro Cc: dledford@redhat.com, linux-rdma@vger.kernel.org, Mike Marciniszyn , Kaike Wan , stable@vger.kernel.org, James Erwin Subject: Re: [PATCH for-rc 1/4] IB/hfi1: Allow for all speeds higher than gen3 Message-ID: <20191029195214.GA1802@ziepe.ca> References: <20191025161717.106825.14421.stgit@awfm-01.aw.intel.com> <20191025195823.106825.63080.stgit@awfm-01.aw.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191025195823.106825.63080.stgit@awfm-01.aw.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Oct 25, 2019 at 03:58:24PM -0400, Dennis Dalessandro wrote: > From: James Erwin > > The driver avoids the gen3 speed bump when the parent > bus speed isn't identical to gen3, 8.0GT/s. This is not > compatible with gen4 and newer speeds. > > Fix by relaxing the test to explicitly look for the lower > capability speeds which inherently allows for all future speeds. This description does not seem like stable material to me. Jason