From: Honggang LI <honli@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Leon Romanovsky <leonro@mellanox.com>,
Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org,
Laurence Oberman <loberman@redhat.com>
Subject: Re: [PATCH] Revert "RDMA/srpt: Postpone HCA removal until after configfs directory removal"
Date: Mon, 4 Nov 2019 09:14:41 +0800 [thread overview]
Message-ID: <20191104011441.GB26981@dhcp-128-227.nay.redhat.com> (raw)
In-Reply-To: <20191101204756.182162-1-bvanassche@acm.org>
On Fri, Nov 01, 2019 at 01:47:56PM -0700, Bart Van Assche wrote:
> Although the mentioned patch fixes a use-after-free bug, it introduces a
> hang during shutdown. Since the latter is worse, revert this patch.
>
> Cc: Honggang Li <honli@redhat.com>
> Cc: Laurence Oberman <loberman@redhat.com>
> Reported-by: Honggang Li <honli@redhat.com>
> Fixes: 9b64f7d0bb0a ("RDMA/srpt: Postpone HCA removal until after configfs directory removal")
> Signed-off-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index c9972b686c27..53dec7d9829c 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2960,7 +2960,7 @@ static int srpt_release_sport(struct srpt_port *sport)
>
> while (atomic_read(&sport->refcount) > 0 &&
> wait_for_completion_timeout(&c, 5 * HZ) <= 0) {
> - pr_info("%s_%d: waiting for unregistration of %d sessions and configfs directories ...\n",
> + pr_info("%s_%d: waiting for unregistration of %d sessions ...\n",
> dev_name(&sport->sdev->device->dev), sport->port,
> atomic_read(&sport->refcount));
> rcu_read_lock();
> @@ -3776,8 +3776,6 @@ static struct se_portal_group *srpt_make_tpg(struct se_wwn *wwn,
> list_add_tail(&stpg->entry, &sport_id->tpg_list);
> mutex_unlock(&sport_id->mutex);
>
> - atomic_inc(&sport->refcount);
> -
> return &stpg->tpg;
> }
>
> @@ -3798,7 +3796,6 @@ static void srpt_drop_tpg(struct se_portal_group *tpg)
> sport->enabled = false;
> core_tpg_deregister(tpg);
> kfree(stpg);
> - srpt_drop_sport_ref(sport);
> }
>
Acked-by: Honggang Li <honli@redhat.com>
> /**
> --
> 2.24.0.rc1.363.gb1bccd3e3d-goog
>
next prev parent reply other threads:[~2019-11-04 1:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 20:47 [PATCH] Revert "RDMA/srpt: Postpone HCA removal until after configfs directory removal" Bart Van Assche
2019-11-04 1:14 ` Honggang LI [this message]
2019-11-06 17:45 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104011441.GB26981@dhcp-128-227.nay.redhat.com \
--to=honli@redhat.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leonro@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).