* [PATCH rdma-core] cxgb4: free appropriate pointer in error case
@ 2019-11-04 11:14 Potnuri Bharat Teja
2019-11-04 11:45 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Potnuri Bharat Teja @ 2019-11-04 11:14 UTC (permalink / raw)
To: jgg, dledford; +Cc: linux-rdma, bharat, nirranjan
Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs")
Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
---
providers/cxgb4/dev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c
index 7f5955449ca1..4d02c7a91892 100644
--- a/providers/cxgb4/dev.c
+++ b/providers/cxgb4/dev.c
@@ -203,9 +203,9 @@ err_free:
if (rhp->cqid2ptr)
free(rhp->cqid2ptr);
if (rhp->qpid2ptr)
- free(rhp->cqid2ptr);
+ free(rhp->qpid2ptr);
if (rhp->mmid2ptr)
- free(rhp->cqid2ptr);
+ free(rhp->mmid2ptr);
verbs_uninit_context(&context->ibv_ctx);
free(context);
return NULL;
--
2.3.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH rdma-core] cxgb4: free appropriate pointer in error case
2019-11-04 11:14 [PATCH rdma-core] cxgb4: free appropriate pointer in error case Potnuri Bharat Teja
@ 2019-11-04 11:45 ` Leon Romanovsky
2019-11-04 12:21 ` Potnuri Bharat Teja
0 siblings, 1 reply; 4+ messages in thread
From: Leon Romanovsky @ 2019-11-04 11:45 UTC (permalink / raw)
To: Potnuri Bharat Teja; +Cc: jgg, dledford, linux-rdma, nirranjan
On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote:
> Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs")
> Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> ---
We are not super-excited to see patches with empty commit message.
Care to send PR to rdma-core? It will be easier for us to merge it.
Thanks
> providers/cxgb4/dev.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c
> index 7f5955449ca1..4d02c7a91892 100644
> --- a/providers/cxgb4/dev.c
> +++ b/providers/cxgb4/dev.c
> @@ -203,9 +203,9 @@ err_free:
> if (rhp->cqid2ptr)
> free(rhp->cqid2ptr);
> if (rhp->qpid2ptr)
> - free(rhp->cqid2ptr);
> + free(rhp->qpid2ptr);
> if (rhp->mmid2ptr)
> - free(rhp->cqid2ptr);
> + free(rhp->mmid2ptr);
> verbs_uninit_context(&context->ibv_ctx);
> free(context);
> return NULL;
> --
> 2.3.9
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH rdma-core] cxgb4: free appropriate pointer in error case
2019-11-04 11:45 ` Leon Romanovsky
@ 2019-11-04 12:21 ` Potnuri Bharat Teja
2019-11-04 15:56 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Potnuri Bharat Teja @ 2019-11-04 12:21 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: jgg, dledford, linux-rdma, Nirranjan Kirubaharan
On Monday, November 11/04/19, 2019 at 17:15:48 +0530, Leon Romanovsky wrote:
> On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote:
> > Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs")
> > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> > ---
>
> We are not super-excited to see patches with empty commit message.
My bad sent an older one instead. Shall resend the right one.
> Care to send PR to rdma-core? It will be easier for us to merge it.
This is how i do for rdma-core patches. first sent to mailing list and then
send a PR. Is it the other way?
>
> Thanks
>
> > providers/cxgb4/dev.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/providers/cxgb4/dev.c b/providers/cxgb4/dev.c
> > index 7f5955449ca1..4d02c7a91892 100644
> > --- a/providers/cxgb4/dev.c
> > +++ b/providers/cxgb4/dev.c
> > @@ -203,9 +203,9 @@ err_free:
> > if (rhp->cqid2ptr)
> > free(rhp->cqid2ptr);
> > if (rhp->qpid2ptr)
> > - free(rhp->cqid2ptr);
> > + free(rhp->qpid2ptr);
> > if (rhp->mmid2ptr)
> > - free(rhp->cqid2ptr);
> > + free(rhp->mmid2ptr);
> > verbs_uninit_context(&context->ibv_ctx);
> > free(context);
> > return NULL;
> > --
> > 2.3.9
> >
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH rdma-core] cxgb4: free appropriate pointer in error case
2019-11-04 12:21 ` Potnuri Bharat Teja
@ 2019-11-04 15:56 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2019-11-04 15:56 UTC (permalink / raw)
To: Potnuri Bharat Teja; +Cc: jgg, dledford, linux-rdma, Nirranjan Kirubaharan
On Mon, Nov 04, 2019 at 05:51:50PM +0530, Potnuri Bharat Teja wrote:
> On Monday, November 11/04/19, 2019 at 17:15:48 +0530, Leon Romanovsky wrote:
> > On Mon, Nov 04, 2019 at 04:44:10PM +0530, Potnuri Bharat Teja wrote:
> > > Fixes: 9b2d3af5735e ("Query device to get the max supported stags, qps, and cqs")
> > > Signed-off-by: Potnuri Bharat Teja <bharat@chelsio.com>
> > > ---
> >
> > We are not super-excited to see patches with empty commit message.
> My bad sent an older one instead. Shall resend the right one.
> > Care to send PR to rdma-core? It will be easier for us to merge it.
> This is how i do for rdma-core patches. first sent to mailing list and then
> send a PR. Is it the other way?
You can skip sending patches to ML for trivial ones.
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-04 15:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-04 11:14 [PATCH rdma-core] cxgb4: free appropriate pointer in error case Potnuri Bharat Teja
2019-11-04 11:45 ` Leon Romanovsky
2019-11-04 12:21 ` Potnuri Bharat Teja
2019-11-04 15:56 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).