From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7A24C43331 for ; Fri, 8 Nov 2019 01:16:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9791321D7B for ; Fri, 8 Nov 2019 01:16:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="h1h5lsiT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728265AbfKHBQ6 (ORCPT ); Thu, 7 Nov 2019 20:16:58 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:43971 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725930AbfKHBQ5 (ORCPT ); Thu, 7 Nov 2019 20:16:57 -0500 Received: by mail-qk1-f194.google.com with SMTP id z23so3816838qkj.10 for ; Thu, 07 Nov 2019 17:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=dyxeSBJVMYqSSgHrMoCBX1xHiPyaBtHHDx9vh0MyLbg=; b=h1h5lsiTzQmb05+dMRootsjogeunEVA0ty19WeFHKl9612U7UhX9X9zXNdFtny0hqQ Xqwnwc/MOy6f/0IsssM+UaqLFVSvo+SoauHQwoqERiAPQyhRSwTo+LaqXpJ2IyHn+QVD j3ox7wthRD+ghEUdMcDMAasfX+J/8FtSRE66I2N1m88bW8TLdhk5J8/I4dRZyDUGDNnj NcW9JRQkaafLVWRRw9pni54fhdg221ogcm3W4kmcrV/hfle4c7agV8zXuYO35bns+Wd2 FM2of8IAkzVZqc3kBYbzrmbXjHX179DAIDuc6wMDiOutAzeUzaLjyCtxvblfELxvXvgO M8Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=dyxeSBJVMYqSSgHrMoCBX1xHiPyaBtHHDx9vh0MyLbg=; b=oYnFtrZnrs1nl+CIugtYYRHeruleK+q1yTUuj6hbFZ+UEjgwvcyaybOppiC06CDB3a +/KE5swDosfQFvNEJFYZ6NQiEZMGmb6zRZR8A4K2mKms9Z8LvhXi3LX35j2+ctkX9dTE jXArQ1em1LBB/Nw2yOl+I+6j90Ol+5hxFHG8Xl8ULaW7bXinO8dOGJEa434rv7o9ceuO xKk7L+1R6HpDMFs8as4/Lh6QBwBIyMcDeCT4jjsWoeNhXCY3p+OJnaSz5Q1mvlE+Z0Ev AI6Ebj47nbQu9ks3KnaXDq/FsvUIfdJVisrb0rmh8pRdLs7XCpXvHUfk9XOiJpASt+fC dk+g== X-Gm-Message-State: APjAAAXP5QeyzYRq0TGFiun8jMUFFHSinxRF+Q5qAEt/WqIvC49YMkxw jfpRm3sp6097nxuHcBRZFynY0g== X-Google-Smtp-Source: APXvYqx4DFWX5SNNZl7pjgak86Wa5yCfVWQdSXhfRgO4TjXogQeQyxfBpCD/iqC0hyFp+0USDCQ+EA== X-Received: by 2002:a05:620a:6ce:: with SMTP id 14mr6624068qky.202.1573175816907; Thu, 07 Nov 2019 17:16:56 -0800 (PST) Received: from cakuba ([65.196.126.174]) by smtp.gmail.com with ESMTPSA id z7sm3448762qth.85.2019.11.07.17.16.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2019 17:16:56 -0800 (PST) Date: Thu, 7 Nov 2019 20:16:53 -0500 From: Jakub Kicinski To: Parav Pandit Cc: "alex.williamson@redhat.com" , "davem@davemloft.net" , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" , Saeed Mahameed , "kwankhede@nvidia.com" , "leon@kernel.org" , "cohuck@redhat.com" , Jiri Pirko , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH net-next 16/19] net/mlx5: Implement dma ops and params for mediated device Message-ID: <20191107201653.0afb51fb@cakuba> In-Reply-To: References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-16-parav@mellanox.com> <20191107154256.21629e5a@cakuba.netronome.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, 7 Nov 2019 21:30:41 +0000, Parav Pandit wrote: > > -----Original Message----- > > From: kvm-owner@vger.kernel.org On Behalf > > Of Jakub Kicinski > > Sent: Thursday, November 7, 2019 2:43 PM > > To: Parav Pandit > > Cc: alex.williamson@redhat.com; davem@davemloft.net; > > kvm@vger.kernel.org; netdev@vger.kernel.org; Saeed Mahameed > > ; kwankhede@nvidia.com; leon@kernel.org; > > cohuck@redhat.com; Jiri Pirko ; linux- > > rdma@vger.kernel.org > > Subject: Re: [PATCH net-next 16/19] net/mlx5: Implement dma ops and params > > for mediated device Please try to avoid generating those headers, you're not an occasional contributor. They're annoying and a waste of space :( > > On Thu, 7 Nov 2019 10:08:31 -0600, Parav Pandit wrote: > > > Implement dma ops wrapper to divert dma ops to its parent PCI device > > > because Intel IOMMU (and may be other IOMMU) is limited to PCI devices. > > > > > > Reviewed-by: Saeed Mahameed > > > Signed-off-by: Parav Pandit > > > > Isn't this supposed to use PASSID or whatnot? Could you explain a little? This > > mdev stuff is pretty new to networking folks.. > > Currently series doesn't support PCI PASID. > While doing dma mapping, Intel IOMMU expects dma device to be PCI device in few function traces like, find_or_alloc_domain(), > Since mdev bus is not a PCI bus, DMA mapping needs to go through its parent PCI device. > Otherwise dma ops on mdev devices fails, as I think it fails to identify how to perform the translations. > (It doesn't seem to consult its parent device). What's missing for PASSID to work? HW support? FW support? IOMMU plumbing? mdev plumbing? mlx5 plumbing?