From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6E4AFC6194 for ; Fri, 8 Nov 2019 09:30:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FBDC222C2 for ; Fri, 8 Nov 2019 09:30:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="0NSpx/ID" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730308AbfKHJaF (ORCPT ); Fri, 8 Nov 2019 04:30:05 -0500 Received: from mail-wm1-f65.google.com ([209.85.128.65]:53744 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731672AbfKHJaF (ORCPT ); Fri, 8 Nov 2019 04:30:05 -0500 Received: by mail-wm1-f65.google.com with SMTP id x4so5401610wmi.3 for ; Fri, 08 Nov 2019 01:30:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=eRd0zmMB4Oip3e8n6DWloWHkrMJLlIZOg5WL86fDovg=; b=0NSpx/IDuQdnoIZy19Y0yM2QJt58YDICwJ4a7AMmOg48/omhFz00Y3Q7fjfm/u43pS qJoPv2TxzTidCqU4Yk+KCzg8RliD/nMvHjLYCL9c0cX0jN2V4noSCASC26saLAeIkPqY B0I+MLE22D+vDwKXA0hKALOrmVcEu1pRQ3Cv24z6vZhCi8eIhlJEEQvsQoPv5syyEA3+ KHHBcFYYgqqe9H7QLxc9f4OtSkxXu1KaZJBSfRVoce1L7aKqElEruVQJRS6ejpTcibWr FSD5MV3h+aYhvB97vgIWI2eXYP9O93ZIcdrpsz9ulyaPcr83FZrftkrKcCREv4DCmhgo v63w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=eRd0zmMB4Oip3e8n6DWloWHkrMJLlIZOg5WL86fDovg=; b=iLsH79ZG19PC4i1jwFEFrPZ/G6KFe0tgG+Ri/RSwRFObJmrI9llSh28d0GvxWrPnFU qKZwtxyEhACBXX5I+1J7F1KIb0SILRcFH2Mz+K+LKGZ/lrYf5HNxXaFBiUJT7Jw9F/vZ sRdUeQMuvcN8h63liNgXAQHUNetS+kStCho1nnBn2IfAGe7F/DDdjltaY3RjPKl8jIuK emXCCacR2McE17VBytHkMNRsot/p2AdHdMpnkA8hpKe98uxNprW0vU0aoBZesyDJGI38 W2Sg/Bhn4t8YY9XxKPacUpz6PlXTZixQ4nYJcrHNrYhopi7FEyykV3GlUaX0ODf4qmwl +6mw== X-Gm-Message-State: APjAAAX885BapvqKrZbtoYj3LyGqXBjpWpKp1kktObXzq1wT24J7k8VT sF697b/3vpMHWK559mhbnDI0aA== X-Google-Smtp-Source: APXvYqxFxGq6zoV4dqGUNzRMeIm6xAvEtpyaWMtpTKpSJPx4AuHUcLsFpiL3EB2rj/hFxjSgv7WKcg== X-Received: by 2002:a7b:c408:: with SMTP id k8mr7630339wmi.67.1573205402525; Fri, 08 Nov 2019 01:30:02 -0800 (PST) Received: from localhost (ip-94-113-220-175.net.upcbroadband.cz. [94.113.220.175]) by smtp.gmail.com with ESMTPSA id z13sm5907160wrm.64.2019.11.08.01.30.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 01:30:02 -0800 (PST) Date: Fri, 8 Nov 2019 10:30:01 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: Parav Pandit , "alex.williamson@redhat.com" , "davem@davemloft.net" , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" , Saeed Mahameed , "kwankhede@nvidia.com" , "leon@kernel.org" , "cohuck@redhat.com" , Jiri Pirko , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH net-next 12/19] devlink: Introduce mdev port flavour Message-ID: <20191108093001.GA6990@nanopsycho> References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-12-parav@mellanox.com> <20191107153836.29c09400@cakuba.netronome.com> <20191107201750.6ac54aed@cakuba> <20191107212024.61926e11@cakuba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107212024.61926e11@cakuba> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fri, Nov 08, 2019 at 03:20:24AM CET, jakub.kicinski@netronome.com wrote: >On Fri, 8 Nov 2019 01:44:53 +0000, Parav Pandit wrote: [...] >> > > > > @@ -6649,6 +6678,9 @@ static int >> > > > __devlink_port_phys_port_name_get(struct devlink_port *devlink_port, >> > > > > n = snprintf(name, len, "pf%uvf%u", >> > > > > attrs->pci_vf.pf, attrs->pci_vf.vf); >> > > > > break; >> > > > > + case DEVLINK_PORT_FLAVOUR_MDEV: >> > > > > + n = snprintf(name, len, "p%s", attrs->mdev.mdev_alias); >> > > > >> > > > Didn't you say m$alias in the cover letter? Not p$alias? >> > > > >> > > In cover letter I described the naming scheme for the netdevice of the >> > > mdev device (not the representor). Representor follows current unique >> > > phys_port_name method. >> > >> > So we're reusing the letter that normal ports use? >> > >> I initially had 'm' as prefix to make it easy to recognize as mdev's port, instead of 'p', but during internal review Jiri's input was to just use 'p'. > >Let's way for Jiri to weigh in then. Hmm, it's been so far I can't really recall. But looking at what we have now: DEVLINK_PORT_FLAVOUR_PHYSICAL "p%u"/"p%us%u" DEVLINK_PORT_FLAVOUR_PCI_PF "pf%u" DEVLINK_PORT_FLAVOUR_PCI_VF "pf%uvf%u" For mdev, the ideal format would be: "pf%um%s" or "pf%uvf%um%s", but that would be too long. I guess that "m%s" is fine. "p" is probably not a good idea as phys ports already have that. [...]