From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47324FA372C for ; Fri, 8 Nov 2019 10:32:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 196C021848 for ; Fri, 8 Nov 2019 10:32:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="tb4sJLDi" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731570AbfKHKcx (ORCPT ); Fri, 8 Nov 2019 05:32:53 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:34539 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfKHKcx (ORCPT ); Fri, 8 Nov 2019 05:32:53 -0500 Received: by mail-wm1-f67.google.com with SMTP id v3so7010396wmh.1 for ; Fri, 08 Nov 2019 02:32:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=/1599gDqgQT4+/ACcw8+n9g4WwihJtSkWdJ83xtYrrs=; b=tb4sJLDi3Exe9JAsUa23Y+q1nk0BHHKEf85IQjE8dNvtPaxihDfBjebMrPHoN/i/nR re4YFq0qshzrfoskQMQ6QXs9iloB9UOmtKTi4RyZTaX1HZZYNynxRU5WmeROLB5HNUhT REcqzGm6BBj0Lh7ByTWCfz3V3pSZQh7tDnSEipHlxYO+e6+jWLPN78gtUqUlXlNOfH7o Q4pHpeAewlMluV03h3vVb2Nk+rVOf8Wfd7+FnAxvEoLKsbAyftjMv2Zpeb9F9/Q+wqvn 8dgi9Lz7CnUVVshn17/hHQgRMiNIGdcoLjpURMVK6oT0AHZt2hVJrLj7i/S3khN7AfsW m5GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=/1599gDqgQT4+/ACcw8+n9g4WwihJtSkWdJ83xtYrrs=; b=AJ1i3BPanemi5/GOii+HMP+baJbKBcXeFej51xEiKGnZer0vx/pkSPt8SziIip7O5k AUlY3BYEPVPvh5zAqjdz5Ibi9zUkLAiU9/xRL9uqn0EV/F80nGmYqizym/CJRu1vC7CX G0o9xiQxszWSLdLdsNZXwWMH1XIcIqt6Kbj/iPjaAorz2hfXrbP21RC1itPSDzm7//I9 6rKeWVVawqniqFVrR16mZXhG+Xx5fdSUm9IAr8yoEXSSTFurJvnvJ82pxxCw49O+LTSf X+AnJYPO+eb3tpdb1t+2z3f3UTDjwcx6DgQ+F4hJBdXYD0wqNlS3ihq3S9BRlPdRiWJk aMWw== X-Gm-Message-State: APjAAAXzBWBgh+550oQbP9FStAKV1igQU1a5ezQ6M9iUiU5hamR/kYzo nYX+U+loAzuacZ0W9BWZW2KYxQ== X-Google-Smtp-Source: APXvYqxP9nvHJSdV76uw+81FjfoIdq73P2BH1K7A+UszgAXvHwfbJNXN8UNx4RKJgQCCFfnklok1PQ== X-Received: by 2002:a1c:6885:: with SMTP id d127mr7243732wmc.64.1573209170449; Fri, 08 Nov 2019 02:32:50 -0800 (PST) Received: from localhost (ip-94-113-220-175.net.upcbroadband.cz. [94.113.220.175]) by smtp.gmail.com with ESMTPSA id a5sm5462412wrv.56.2019.11.08.02.32.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 02:32:50 -0800 (PST) Date: Fri, 8 Nov 2019 11:32:49 +0100 From: Jiri Pirko To: Parav Pandit Cc: alex.williamson@redhat.com, davem@davemloft.net, kvm@vger.kernel.org, netdev@vger.kernel.org, saeedm@mellanox.com, kwankhede@nvidia.com, leon@kernel.org, cohuck@redhat.com, jiri@mellanox.com, linux-rdma@vger.kernel.org, Vu Pham Subject: Re: [PATCH net-next 06/19] net/mlx5: Add support for mediated devices in switchdev mode Message-ID: <20191108103249.GE6990@nanopsycho> References: <20191107160448.20962-1-parav@mellanox.com> <20191107160834.21087-1-parav@mellanox.com> <20191107160834.21087-6-parav@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107160834.21087-6-parav@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Thu, Nov 07, 2019 at 05:08:21PM CET, parav@mellanox.com wrote: >From: Vu Pham [...] >+static ssize_t >+max_mdevs_show(struct kobject *kobj, struct device *dev, char *buf) >+{ >+ struct pci_dev *pdev = to_pci_dev(dev); >+ struct mlx5_core_dev *coredev; >+ struct mlx5_mdev_table *table; >+ u16 max_sfs; >+ >+ coredev = pci_get_drvdata(pdev); >+ table = coredev->priv.eswitch->mdev_table; >+ max_sfs = mlx5_core_max_sfs(coredev, &table->sf_table); >+ >+ return sprintf(buf, "%d\n", max_sfs); >+} >+static MDEV_TYPE_ATTR_RO(max_mdevs); >+ >+static ssize_t >+available_instances_show(struct kobject *kobj, struct device *dev, char *buf) >+{ >+ struct pci_dev *pdev = to_pci_dev(dev); >+ struct mlx5_core_dev *coredev; >+ struct mlx5_mdev_table *table; >+ u16 free_sfs; >+ >+ coredev = pci_get_drvdata(pdev); >+ table = coredev->priv.eswitch->mdev_table; >+ free_sfs = mlx5_get_free_sfs(coredev, &table->sf_table); >+ return sprintf(buf, "%d\n", free_sfs); >+} >+static MDEV_TYPE_ATTR_RO(available_instances); These 2 arbitrary sysfs files are showing resource size/usage for the whole eswitch/asic. That is a job for "devlink resource". Please implement that. >+ >+static struct attribute *mdev_dev_attrs[] = { >+ &mdev_type_attr_max_mdevs.attr, >+ &mdev_type_attr_available_instances.attr, >+ NULL, >+}; >+ >+static struct attribute_group mdev_mgmt_group = { >+ .name = "local", >+ .attrs = mdev_dev_attrs, >+}; >+ >+static struct attribute_group *mlx5_meddev_groups[] = { >+ &mdev_mgmt_group, >+ NULL, >+}; [...]