From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_SBL,URIBL_SBL_A,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48A96FC6195 for ; Fri, 8 Nov 2019 18:34:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 218672075C for ; Fri, 8 Nov 2019 18:34:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="GBKXo9ZR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726394AbfKHSeP (ORCPT ); Fri, 8 Nov 2019 13:34:15 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:37930 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728852AbfKHSeP (ORCPT ); Fri, 8 Nov 2019 13:34:15 -0500 Received: by mail-wr1-f68.google.com with SMTP id i12so1239853wro.5 for ; Fri, 08 Nov 2019 10:34:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lDOuVdyU/NGOBA/NOIi8OTDcCGXKckSDWCSgU9rLWOY=; b=GBKXo9ZRoH0e4wUtSlIUb3jLlN2tyv9jvO1lXk+hjiCvbGNWQclRoE+DnjB/QX5s41 n5jw9WlfRYPle46v3JyStnKYvmiB68HHm8MwEc3LtJM1565Q1c29Wy5nndmi1oxHjKOQ e7gd9wD8Ru/6hhdn7UBLdZGgDSRNNPxEUGue3/3568fVQ2SrfWs0EqyFeSGE11HwoaMs LO6A3HRwfGUZBpn1zOYHoo+pC/UlzOfXuxJ0mUntwb/fEO/PP6PPwhCtZzRzMcMPLzbL Osn7dwCJpldAT3RahOhb3EB8blyvIRKuPLxwioaGSwTuP2RiKOFctQJMUk2muhn7Xofs yOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lDOuVdyU/NGOBA/NOIi8OTDcCGXKckSDWCSgU9rLWOY=; b=a1GthNGuvUZtG6BhWRJZfaEuNM6ip+SdcmEWy7HyeTbA9mmjt4c63lRs/aqSelHyl5 CxI0cyeVpNXbo8tRydR/BZx0vxk3S8UBOvsiIxHCtG9qsoPhlysI09oGD+LbtkDzCeYv cCx5qYr5LyP+zrCvjZsV9OhEddx8RG4Gu5XuZsfmds3irfpAwt5uXOFpg/8JHUppYalR KN0InB9MFl4nzPr41UBGjM8sb12MRl3MIs06Y9VBi4VotNC8LBuPuxM+Qix4QAWhOkym FvLEkUU4R8OWUxLIV4W8MzC5couJGChKWU+jdEjXpdAMc9H9bOPupKzWX2cgwCuP3g3Y kfhw== X-Gm-Message-State: APjAAAViGArRSCANBoymepLqmcg/kB76aWlYcZV3yiR+TjROgyDsw7ox PfQL3VjojTAv6TrOTdCiXLwq1g== X-Google-Smtp-Source: APXvYqxLI+jBORt6enjDcoO/Lv3XygiUH9GQ1c32a7/0zht8rn1PTzF2lBpOGDEQ2Gc6QciF69dDcA== X-Received: by 2002:adf:c401:: with SMTP id v1mr9446418wrf.375.1573238053124; Fri, 08 Nov 2019 10:34:13 -0800 (PST) Received: from localhost (ip-94-113-220-175.net.upcbroadband.cz. [94.113.220.175]) by smtp.gmail.com with ESMTPSA id p25sm3094919wma.20.2019.11.08.10.34.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Nov 2019 10:34:12 -0800 (PST) Date: Fri, 8 Nov 2019 19:34:11 +0100 From: Jiri Pirko To: Parav Pandit Cc: Jakub Kicinski , "alex.williamson@redhat.com" , "davem@davemloft.net" , "kvm@vger.kernel.org" , "netdev@vger.kernel.org" , Saeed Mahameed , "kwankhede@nvidia.com" , "leon@kernel.org" , "cohuck@redhat.com" , Jiri Pirko , "linux-rdma@vger.kernel.org" Subject: Re: [PATCH net-next 12/19] devlink: Introduce mdev port flavour Message-ID: <20191108183411.GW6990@nanopsycho> References: <20191107201750.6ac54aed@cakuba> <20191107212024.61926e11@cakuba> <20191108094646.GB6990@nanopsycho> <20191108163139.GQ6990@nanopsycho> <20191108181119.GT6990@nanopsycho> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org Fri, Nov 08, 2019 at 07:23:44PM CET, parav@mellanox.com wrote: > > >> -----Original Message----- >> From: Jiri Pirko > >[..] >> Well, I don't really need those in the phys_port_name, mainly simply because >> they would not fit. However, I believe that you should fillup the PF/VF devlink >> netlink attrs. >> >> Note that we are not talking here about the actual mdev, but rather >> devlink_port associated with this mdev. And devlink port should have this info. >> >> >> > >> >> >What in hypothetical case, mdev is not on top of PCI... >> >> >> >> Okay, let's go hypothetical. In that case, it is going to be on top >> >> of something else, wouldn't it? >> >Yes, it will be. But just because it is on top of something, doesn't mean we >> include the whole parent dev, its bridge, its rc hierarchy here. >> >There should be a need. >> >It was needed in PF/VF case due to overlapping numbers of VFs via single >> devlink instance. You probably missed my reply to Jakub. >> >> Sure. Again, I don't really care about having that in phys_port_name. >> But please fillup the attrs. >> >Ah ok. but than that would be optional attribute? >Because you can have non pci based mdev, though it doesn't exist today along with devlink to my knowledge. Non-optional now. We can always change the code to not fill it up or fill up another attr instead. no UAPI harm.