linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Doug Ledford <dledford@redhat.com>,
	RDMA mailing list <linux-rdma@vger.kernel.org>,
	Mike Marciniszyn <mike.marciniszyn@intel.com>,
	Ralph Campbell <ralph.campbell@qlogic.com>
Subject: Re: [PATCH rdma-next 00/16] MAD cleanup
Date: Mon, 11 Nov 2019 17:06:46 +0200	[thread overview]
Message-ID: <20191111150646.GW6763@unreal> (raw)
In-Reply-To: <20191106201448.GA25345@ziepe.ca>

On Wed, Nov 06, 2019 at 04:14:48PM -0400, Jason Gunthorpe wrote:
> On Tue, Oct 29, 2019 at 08:27:29AM +0200, Leon Romanovsky wrote:
> > From: Leon Romanovsky <leonro@mellanox.com>
> >
> > Let's clean MAD code a little bit.
> >
> > It is based on
> > https://lore.kernel.org/linux-rdma/20191027070621.11711-1-leon@kernel.org
>
> It doesn't seem related to this at all
>
> > Leon Romanovsky (16):
> >   RDMA/mad: Delete never implemented functions
> >   RDMA/mad: Allocate zeroed MAD buffer
> >   RDMA/mlx4: Delete redundant zero memset
> >   RDMA/mlx5: Delete redundant zero memset
>
> We don't need a patch for every driver just to change the same
> repeating 2 line pattern, I squashed these
>
> >   RDMA/ocrdma: Clean MAD processing logic
> >   RDMA/qib: Delete redundant memset for MAD output buffer
> >   RDMA/mlx4: Delete unreachable code
> >   RDMA/mlx5: Delete unreachable code
> >   RDMA/mthca: Delete unreachable code
>
> Same here
>
> >   RDMA/ocrdma: Simplify process_mad function
> >   RDMA/qib: Delete unreachable code
> >   RDMA/mlx5: Rewrite MAD processing logic to be readable
> >   RDMA/qib: Delete extra line
>
> >   RDMA/qib: Delete unused variable in process_cc call
>
> This is actually a bug from an earlier patch that oddly removed
> check_cc_key, I put that into its own patch
>
> >   RDMA/hfi1: Delete unreachable code
> >   RDMA: Change MAD processing function to remove extra casting and
> >     parameter
>
> Ira seems concerned, so I didn't apply these until we hear from Dennis
>
> Otherwise the rest were applied with re-organization to for-next

Jason,

Can you please take missing two patches?

Thanks

>
> Thanks,
> Jason

  reply	other threads:[~2019-11-11 15:06 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29  6:27 [PATCH rdma-next 00/16] MAD cleanup Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 01/16] RDMA/mad: Delete never implemented functions Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 02/16] RDMA/mad: Allocate zeroed MAD buffer Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 03/16] RDMA/mlx4: Delete redundant zero memset Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 04/16] RDMA/mlx5: " Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 05/16] RDMA/ocrdma: Clean MAD processing logic Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 06/16] RDMA/qib: Delete redundant memset for MAD output buffer Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 07/16] RDMA/hfi1: Delete unreachable code Leon Romanovsky
2019-10-29 23:33   ` Ira Weiny
2019-10-30  0:02     ` Ira Weiny
2019-10-29  6:27 ` [PATCH rdma-next 08/16] RDMA/mlx4: " Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 09/16] RDMA/mlx5: " Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 10/16] RDMA/mthca: " Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 11/16] RDMA/ocrdma: Simplify process_mad function Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 12/16] RDMA/qib: Delete unreachable code Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 13/16] RDMA/mlx5: Rewrite MAD processing logic to be readable Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 14/16] RDMA/qib: Delete extra line Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 15/16] RDMA/qib: Delete unused variable in process_cc call Leon Romanovsky
2019-10-29  6:27 ` [PATCH rdma-next 16/16] RDMA: Change MAD processing function to remove extra casting and parameter Leon Romanovsky
2019-11-11 13:33   ` Marciniszyn, Mike
2019-11-11 15:06     ` Leon Romanovsky
2019-11-06 20:14 ` [PATCH rdma-next 00/16] MAD cleanup Jason Gunthorpe
2019-11-11 15:06   ` Leon Romanovsky [this message]
2019-11-13  0:37 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111150646.GW6763@unreal \
    --to=leon@kernel.org \
    --cc=dledford@redhat.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mike.marciniszyn@intel.com \
    --cc=ralph.campbell@qlogic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).