From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6491C432C0 for ; Mon, 18 Nov 2019 07:49:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B0CB62067D for ; Mon, 18 Nov 2019 07:49:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574063379; bh=AV6l9cxsDAG2ISoLdHp8DlACnAVdJD/5/GbndswB/1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=mopziWhg+ApJ/GrpYeAZLQdPjwbHK9NZGq15CwM0dRgY6N7iLHtYWYLAgmhC9akCQ dIcQzj0d0/f9HvkVtEVyBkytbe5HYbzuuGdSYmL/dkX4yKa8zReZfCpaH+1GxJaQyQ +njURVwCJkBLCbgtR9z6MTJe2tAzWY8NT9x/Zazs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726595AbfKRHtj (ORCPT ); Mon, 18 Nov 2019 02:49:39 -0500 Received: from mail.kernel.org ([198.145.29.99]:34358 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726316AbfKRHtj (ORCPT ); Mon, 18 Nov 2019 02:49:39 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6779920679; Mon, 18 Nov 2019 07:49:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574063378; bh=AV6l9cxsDAG2ISoLdHp8DlACnAVdJD/5/GbndswB/1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n41iPHjumO1lzpsuR34iOWDok/tp4N4kDm1lRL4KphTv9fMt3VIz89RiJEPT3LvqE ai0wa5gKmqvZugyc47frMUZ7TbQ7ZRwvxj0hCcyu3z1rLce6nSD6n0hSyoxxe7rPNG q8L7HYdgZ+mZh4Fcy3ZJNWGndumCWmI2gLIRrIFg= Date: Mon, 18 Nov 2019 08:49:34 +0100 From: Greg KH To: Jeff Kirsher Cc: davem@davemloft.net, Dave Ertman , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jgg@ziepe.ca, parav@mellanox.com, Kiran Patil Subject: Re: [net-next v2 1/1] virtual-bus: Implementation of Virtual Bus Message-ID: <20191118074934.GB130507@kroah.com> References: <20191115223355.1277139-1-jeffrey.t.kirsher@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191115223355.1277139-1-jeffrey.t.kirsher@intel.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Nov 15, 2019 at 02:33:55PM -0800, Jeff Kirsher wrote: > From: Dave Ertman > > This is the initial implementation of the Virtual Bus, > virtbus_device and virtbus_driver. The virtual bus is > a software based bus intended to support lightweight > devices and drivers and provide matching between them > and probing of the registered drivers. > > The primary purpose of the virual bus is to provide > matching services and to pass the data pointer > contained in the virtbus_device to the virtbus_driver > during its probe call. This will allow two separate > kernel objects to match up and start communication. > > The bus will support probe/remove shutdown and > suspend/resume callbacks. > > Kconfig and Makefile alterations are included > > Signed-off-by: Dave Ertman > Signed-off-by: Kiran Patil > Signed-off-by: Jeff Kirsher > --- > v2: Cleaned up the virtual bus interface based on feedback from Greg KH > and provided a test driver and test virtual bus device as an example > of how to implement the virtual bus. There is not a real user of this here, many of your exported functions are not used at all, right? I want to see this in "real use" to actually determine how it works, and that's the only way you will know if it solves your problem or not. thanks, greg k-h