From: Jason Gunthorpe <jgg@ziepe.ca>
To: Gal Pressman <galpress@amazon.com>
Cc: Doug Ledford <dledford@redhat.com>,
linux-rdma@vger.kernel.org,
Daniel Kranzdorf <dkkranzd@amazon.com>,
Yossi Leybovich <sleybo@amazon.com>
Subject: Re: [PATCH for-next 3/3] RDMA/efa: Expose RDMA read related attributes
Date: Tue, 19 Nov 2019 15:56:37 -0400 [thread overview]
Message-ID: <20191119195637.GA17863@ziepe.ca> (raw)
In-Reply-To: <20191112091737.40204-4-galpress@amazon.com>
On Tue, Nov 12, 2019 at 11:17:37AM +0200, Gal Pressman wrote:
> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h
> index 9599a2a62be8..442804572118 100644
> +++ b/include/uapi/rdma/efa-abi.h
> @@ -90,12 +90,21 @@ struct efa_ibv_create_ah_resp {
> __u8 reserved_30[2];
> };
>
> +enum {
> + EFA_QUERY_DEVICE_CAPS_RDMA_READ = 1 << 0,
> +};
This doesn't seem needed, caps should only be used if a zero filled
reply from an old kernel is not OK.
> struct efa_ibv_ex_query_device_resp {
> __u32 comp_mask;
> __u32 max_sq_wr;
> __u32 max_rq_wr;
> __u16 max_sq_sge;
> __u16 max_rq_sge;
> + __u32 max_rdma_size;
> + __u16 max_wr_rdma_sge;
> + __u8 reserved_b0[2];
> + __u32 device_caps;
> + __u8 reserved_e0[4];
> };
This has the same problem as we talked about in userspace, the
max_wr_rdma_sge duplicates the field in the normal query_device
response
Jason
next prev parent reply other threads:[~2019-11-19 19:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 9:17 [PATCH for-next 0/3] EFA RDMA read support Gal Pressman
2019-11-12 9:17 ` [PATCH for-next 1/3] RDMA/efa: Store network attributes in device attributes Gal Pressman
2019-11-12 9:17 ` [PATCH for-next 2/3] RDMA/efa: Support remote read access in MR registration Gal Pressman
2019-11-12 9:17 ` [PATCH for-next 3/3] RDMA/efa: Expose RDMA read related attributes Gal Pressman
2019-11-19 19:56 ` Jason Gunthorpe [this message]
2019-11-19 20:50 ` Gal Pressman
2019-11-19 21:10 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119195637.GA17863@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dkkranzd@amazon.com \
--cc=dledford@redhat.com \
--cc=galpress@amazon.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sleybo@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).