From: Jason Gunthorpe <jgg@ziepe.ca>
To: Michal Kalderon <michal.kalderon@marvell.com>
Cc: dledford@redhat.com, ariel.elior@marvell.com, linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/qedr: Fix null-pointer dereference when calling rdma_user_mmap_get_offset
Date: Tue, 19 Nov 2019 16:18:43 -0400 [thread overview]
Message-ID: <20191119201843.GA6720@ziepe.ca> (raw)
In-Reply-To: <20191118150645.26602-1-michal.kalderon@marvell.com>
On Mon, Nov 18, 2019 at 05:06:45PM +0200, Michal Kalderon wrote:
> When running against rdma-core that doesn't support doorbell
> recovery, the rdma_user_mmap_entry won't be allocated for
> doorbell recovery related mappings.
> We have a flag indicating whether rdma-core supports doorbell
> recovery or not which was used during initialization, however
> some cases didn't check that the rdma_user_mmap_entry exists
> before attempting to acquire it's offset.
>
> Fixes: 97f612509294 ("RDMA/qedr: Add doorbell overflow recovery support")
> Signed-off-by: Ariel Elior <ariel.elior@marvell.com>
> Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>
> ---
> drivers/infiniband/hw/qedr/verbs.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2019-11-19 20:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 15:06 [PATCH rdma-next] RDMA/qedr: Fix null-pointer dereference when calling rdma_user_mmap_get_offset Michal Kalderon
2019-11-19 20:18 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191119201843.GA6720@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=ariel.elior@marvell.com \
--cc=dledford@redhat.com \
--cc=linux-rdma@vger.kernel.org \
--cc=michal.kalderon@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).