From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0C49C432C0 for ; Thu, 21 Nov 2019 08:10:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B628020855 for ; Thu, 21 Nov 2019 08:10:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="tSf+ntFI" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727125AbfKUIKd (ORCPT ); Thu, 21 Nov 2019 03:10:33 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:43222 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726343AbfKUIKc (ORCPT ); Thu, 21 Nov 2019 03:10:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ayytCJcth5GS0yhMc7G3JkwZ14SgYTl8WFFvY2/7v8M=; b=tSf+ntFIx+E4ElPWg7N/YrDA5 DJpdGB/LPxrZKjR8XgqAl2zR85VHA697aheq0Zg246jsWgb8mrSdltGy5yMP9HbBodsPoR+gwGpD+ QVOFwWDZ+KabSirkp4Tt9dB6kmJIUn0J+Il59Ko2Pkv3hkIl+fSJj/KbwMadKof/10NbX4BVK4ecW CzXkmxFI+A8ZBzCm+FXsPX/uDD3s0HAgf0WBL/2Hz3XeBUWuBLfRR+cpozCLlR9UfRS5SZMBsI4/v eMEAVutB9ql9MJsVHEW4sKjJfLq4kUoa0IJZZM6O6F/e7LcxIe5kML6J3bUd6SLeM+OcPR4CPMA97 R/3mfYL1g==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iXhVv-0008IQ-Ap; Thu, 21 Nov 2019 08:08:31 +0000 Date: Thu, 21 Nov 2019 00:08:31 -0800 From: Christoph Hellwig To: John Hubbard Cc: Andrew Morton , Al Viro , Alex Williamson , Benjamin Herrenschmidt , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , Christoph Hellwig , Dan Williams , Daniel Vetter , Dave Chinner , David Airlie , "David S . Miller" , Ira Weiny , Jan Kara , Jason Gunthorpe , Jens Axboe , Jonathan Corbet , =?iso-8859-1?B?Suly9G1l?= Glisse , Magnus Karlsson , Mauro Carvalho Chehab , Michael Ellerman , Michal Hocko , Mike Kravetz , Paul Mackerras , Shuah Khan , Vlastimil Babka , bpf@vger.kernel.org, dri-devel@lists.freedesktop.org, kvm@vger.kernel.org, linux-block@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, netdev@vger.kernel.org, linux-mm@kvack.org, LKML Subject: Re: [PATCH v7 06/24] goldish_pipe: rename local pin_user_pages() routine Message-ID: <20191121080831.GD30991@infradead.org> References: <20191121071354.456618-1-jhubbard@nvidia.com> <20191121071354.456618-7-jhubbard@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191121071354.456618-7-jhubbard@nvidia.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Nov 20, 2019 at 11:13:36PM -0800, John Hubbard wrote: > +static int pin_goldfish_pages(unsigned long first_page, > + unsigned long last_page, > + unsigned int last_page_size, > + int is_write, > + struct page *pages[MAX_BUFFERS_PER_COMMAND], > + unsigned int *iter_last_page_size) Why not goldfish_pin_pages? Normally we put the module / subsystem in front. Also can we get this queued up for 5.5 to get some trivial changes out of the way?