linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Andrew Boyer <aboyer@pensando.io>
Cc: linux-rdma@vger.kernel.org, allenbh@pensando.io
Subject: Re: [PATCH] rdma-core: Recognize IBV_DEVICE_LOCAL_DMA_LKEY in ibv_devinfo
Date: Mon, 25 Nov 2019 13:56:03 -0400	[thread overview]
Message-ID: <20191125175603.GB11270@ziepe.ca> (raw)
In-Reply-To: <20191125152237.19084-1-aboyer@pensando.io>

On Mon, Nov 25, 2019 at 07:22:37AM -0800, Andrew Boyer wrote:
> This bit is defined in the kernel but not displayed by ibv_devinfo.
> 
> Signed-off-by: Andrew Boyer <aboyer@pensando.io>
>  libibverbs/examples/devinfo.c | 3 +++
>  libibverbs/verbs.h            | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/libibverbs/examples/devinfo.c b/libibverbs/examples/devinfo.c
> index bf53eac2..e3210f6e 100644
> +++ b/libibverbs/examples/devinfo.c
> @@ -220,6 +220,7 @@ static void print_device_cap_flags(uint32_t dev_cap_flags)
>  				   IBV_DEVICE_RC_RNR_NAK_GEN |
>  				   IBV_DEVICE_SRQ_RESIZE |
>  				   IBV_DEVICE_N_NOTIFY_CQ |
> +				   IBV_DEVICE_LOCAL_DMA_LKEY |
>  				   IBV_DEVICE_MEM_WINDOW |
>  				   IBV_DEVICE_UD_IP_CSUM |
>  				   IBV_DEVICE_XRC |
> @@ -260,6 +261,8 @@ static void print_device_cap_flags(uint32_t dev_cap_flags)
>  		printf("\t\t\t\t\tSRQ_RESIZE\n");
>  	if (dev_cap_flags & IBV_DEVICE_N_NOTIFY_CQ)
>  		printf("\t\t\t\t\tN_NOTIFY_CQ\n");
> +	if (dev_cap_flags & IBV_DEVICE_LOCAL_DMA_LKEY)
> +		printf("\t\t\t\t\tLOCAL_DMA_LKEY\n");
>  	if (dev_cap_flags & IBV_DEVICE_MEM_WINDOW)
>  		printf("\t\t\t\t\tMEM_WINDOW\n");
>  	if (dev_cap_flags & IBV_DEVICE_UD_IP_CSUM)
> diff --git a/libibverbs/verbs.h b/libibverbs/verbs.h
> index 7b8d4310..81e5812c 100644
> +++ b/libibverbs/verbs.h
> @@ -112,6 +112,7 @@ enum ibv_device_cap_flags {
>  	IBV_DEVICE_RC_RNR_NAK_GEN	= 1 << 12,
>  	IBV_DEVICE_SRQ_RESIZE		= 1 << 13,
>  	IBV_DEVICE_N_NOTIFY_CQ		= 1 << 14,
> +	IBV_DEVICE_LOCAL_DMA_LKEY	= 1 << 15,
>  	IBV_DEVICE_MEM_WINDOW           = 1 << 17,
>  	IBV_DEVICE_UD_IP_CSUM		= 1 << 18,
>  	IBV_DEVICE_XRC			= 1 << 20,

This flag really only has meaning for the kernel, it should come out
of the uapi at all.

It is a mistake that kernel internal bits have been mixed in with
userspace bits.

Jason

  reply	other threads:[~2019-11-25 17:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25 15:22 [PATCH] rdma-core: Recognize IBV_DEVICE_LOCAL_DMA_LKEY in ibv_devinfo Andrew Boyer
2019-11-25 17:56 ` Jason Gunthorpe [this message]
2019-11-25 19:32   ` Andrew Boyer
2019-11-25 20:08     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191125175603.GB11270@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=aboyer@pensando.io \
    --cc=allenbh@pensando.io \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).