From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46143C432C3 for ; Wed, 27 Nov 2019 19:26:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BA562080F for ; Wed, 27 Nov 2019 19:26:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727287AbfK0T0g (ORCPT ); Wed, 27 Nov 2019 14:26:36 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:56736 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727149AbfK0T0g (ORCPT ); Wed, 27 Nov 2019 14:26:36 -0500 Received: from localhost (c-73-35-209-67.hsd1.wa.comcast.net [73.35.209.67]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 97D0514A6F7FF; Wed, 27 Nov 2019 11:26:35 -0800 (PST) Date: Wed, 27 Nov 2019 11:26:35 -0800 (PST) Message-Id: <20191127.112635.1621097212312385906.davem@davemloft.net> To: yuehaibing@huawei.com Cc: saeedm@mellanox.com, leon@kernel.org, eli@mellanox.com, roid@mellanox.com, elibr@mellanox.com, kliteyn@mellanox.com, ozsh@mellanox.com, pablo@netfilter.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/mlx5e: Fix build error without IPV6 From: David Miller In-Reply-To: <20191127132700.25872-1-yuehaibing@huawei.com> References: <20191127132700.25872-1-yuehaibing@huawei.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 27 Nov 2019 11:26:36 -0800 (PST) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: YueHaibing Date: Wed, 27 Nov 2019 21:27:00 +0800 > If IPV6 is not set and CONFIG_MLX5_ESWITCH is y, > building fails: > > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:322:5: error: redefinition of mlx5e_tc_tun_create_header_ipv6 > int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > In file included from drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:7:0: > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:67:1: note: previous definition of mlx5e_tc_tun_create_header_ipv6 was here > mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv, > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Use #ifdef to guard this, also move mlx5e_route_lookup_ipv6 > to cleanup unused warning. > > Reported-by: Hulk Robot > Fixes: e689e998e102 ("net/mlx5e: TC, Stub out ipv6 tun create header function") > Signed-off-by: YueHaibing Saeed et al., how do you want to handle this? Thanks.