From: David Miller <davem@davemloft.net>
To: saeedm@mellanox.com
Cc: yuehaibing@huawei.com, linux-rdma@vger.kernel.org,
kliteyn@mellanox.com, ozsh@mellanox.com, pablo@netfilter.org,
eli@mellanox.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, elibr@mellanox.com, leon@kernel.org,
roid@mellanox.com
Subject: Re: [PATCH] net/mlx5e: Fix build error without IPV6
Date: Sat, 30 Nov 2019 09:42:59 -0800 (PST) [thread overview]
Message-ID: <20191130.094259.2137634376477573408.davem@davemloft.net> (raw)
In-Reply-To: <4da78750d80eb7b6099849ac8ffbae528b6d78e8.camel@mellanox.com>
From: Saeed Mahameed <saeedm@mellanox.com>
Date: Sat, 30 Nov 2019 07:33:48 +0000
> On Wed, 2019-11-27 at 11:26 -0800, David Miller wrote:
>> From: YueHaibing <yuehaibing@huawei.com>
>> Date: Wed, 27 Nov 2019 21:27:00 +0800
>>
>> > If IPV6 is not set and CONFIG_MLX5_ESWITCH is y,
>> > building fails:
>> >
>> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:322:5: error:
>> redefinition of mlx5e_tc_tun_create_header_ipv6
>> > int mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
>> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> > In file included from
>> drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.c:7:0:
>> > drivers/net/ethernet/mellanox/mlx5/core/en/tc_tun.h:67:1: note:
>> previous definition of mlx5e_tc_tun_create_header_ipv6 was here
>> > mlx5e_tc_tun_create_header_ipv6(struct mlx5e_priv *priv,
>> > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> >
>> > Use #ifdef to guard this, also move mlx5e_route_lookup_ipv6
>> > to cleanup unused warning.
>> >
>> > Reported-by: Hulk Robot <hulkci@huawei.com>
>> > Fixes: e689e998e102 ("net/mlx5e: TC, Stub out ipv6 tun create
>> header function")
>> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>>
>> Saeed et al., how do you want to handle this?
>>
>
> LGTM, I guess you can push this to net since this is dealing with a
> build error ?
Ok, I'll do that, thanks.
next prev parent reply other threads:[~2019-11-30 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 13:27 [PATCH] net/mlx5e: Fix build error without IPV6 YueHaibing
2019-11-27 19:26 ` David Miller
2019-11-30 7:33 ` Saeed Mahameed
2019-11-30 17:42 ` David Miller [this message]
2019-11-30 7:32 ` Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191130.094259.2137634376477573408.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eli@mellanox.com \
--cc=elibr@mellanox.com \
--cc=kliteyn@mellanox.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ozsh@mellanox.com \
--cc=pablo@netfilter.org \
--cc=roid@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).