Linux-RDMA Archive on lore.kernel.org
 help / color / Atom feed
From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Tariq Toukan <tariqt@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
	oss-drivers@netronome.com
Subject: Re: [PATCH RFC v7 net-next 3/1] netronome: use the new txqueue timeout argument
Date: Tue, 3 Dec 2019 10:09:31 -0800
Message-ID: <20191203100931.43207030@cakuba.netronome.com> (raw)
In-Reply-To: <20191203072757.429125-2-mst@redhat.com>

On Tue, 3 Dec 2019 02:32:14 -0500, Michael S. Tsirkin wrote:
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> 
> untested
> 
>  drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 41a808b14d76..26f1fb19d0aa 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -1323,13 +1323,8 @@ nfp_net_tx_ring_reset(struct nfp_net_dp *dp, struct nfp_net_tx_ring *tx_ring)
>  static void nfp_net_tx_timeout(struct net_device *netdev, unsigned int txqueue)
>  {
>  	struct nfp_net *nn = netdev_priv(netdev);
> -	int i;
>  
> -	for (i = 0; i < nn->dp.netdev->real_num_tx_queues; i++) {
> -		if (!netif_tx_queue_stopped(netdev_get_tx_queue(netdev, i)))
> -			continue;
> -		nn_warn(nn, "TX timeout on ring: %d\n", i);
> -	}
> +	nn_warn(nn, "TX timeout on ring: %d\n", txqueue);

%u

>  	nn_warn(nn, "TX watchdog timeout\n");

I think we can drop this warning now.

With that:

Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>

Thanks!

      reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191203071101.427592-1-mst@redhat.com>
2019-12-03  7:32 ` [PATCH RFC v7 net-next 2/1] mlx4: use " Michael S. Tsirkin
2019-12-03  7:32   ` [PATCH RFC v7 net-next 3/1] netronome: use the " Michael S. Tsirkin
2019-12-03 18:09     ` Jakub Kicinski [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203100931.43207030@cakuba.netronome.com \
    --to=jakub.kicinski@netronome.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-RDMA Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-rdma/0 linux-rdma/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-rdma linux-rdma/ https://lore.kernel.org/linux-rdma \
		linux-rdma@vger.kernel.org
	public-inbox-index linux-rdma

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-rdma


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git