linux-rdma.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: "Thorben Römer" <thorben.roemer@secunet.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: install-step fails for pandoc-prebuilt man-pages in infiniband-diags/man
Date: Mon, 9 Dec 2019 15:39:36 -0400	[thread overview]
Message-ID: <20191209193936.GA3471@ziepe.ca> (raw)
In-Reply-To: <5d754108-7020-6041-1b7d-bbb3fb2f089b@secunet.com>

On Wed, Dec 04, 2019 at 03:34:14PM +0100, Thorben Römer wrote:

> While investigating, I came up with the following explanation: The
> hashes (generated by buildlib/pandoc-prebuilt.py) differ from machine to
> machine, as the contents of the *.rst-files are hashed. Most of these
> files are processed via cmake's configure_file from *.in.rst-files and
> contain custom-per-build-data such as absolute paths. This means that
> hashing *.rst-files will produce differing hashes based on the
> build-directory-path (among other data points, possibly).

It is not the build directory path, it is the install directory path,
and yes, the no-pandoc builds have to use the standard paths.

> by looking at the hashes produced by two of my machines, they were
> different for all but 3 files (ibcacheedit.8.rst, ibstatus.8.rst and
> check_lft_balance.8.rst). These files (and their includes, as their
> content is also hashed!) are the only files that to not contain any
> differing data when being transformed from *.in.rst to *.rst via
> configure_file, which supports my hypothesis.

This only happens if each machine is configuring to use different
paths, or something has gone quite wrong. What are the actual diffs
from the two .rst's ?

> With my limited time and expertise in the rdma-core project, I was only
> able to come up with a solution that I don't find very practical. I will
> append a diff of pandoc-prebuilt.py nonetheless, which replaces
> hashing-calls for *.rst to *.in.rst if applicable.

This just makes broken output if pandoc is not present, it is not practical.

The only good options is to shift the substition to after
pandoc/rst2man run - but I'm not sure if that is doable..

Jason

  parent reply	other threads:[~2019-12-09 19:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 14:34 install-step fails for pandoc-prebuilt man-pages in infiniband-diags/man Thorben Römer
2019-12-05  8:12 ` Leon Romanovsky
2019-12-09 19:39 ` Jason Gunthorpe [this message]
2019-12-10  7:31   ` Thorben Römer
2019-12-10 17:29     ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209193936.GA3471@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=linux-rdma@vger.kernel.org \
    --cc=thorben.roemer@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).