From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7210CC43603 for ; Wed, 11 Dec 2019 22:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 408422173E for ; Wed, 11 Dec 2019 22:57:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=Mellanox.com header.i=@Mellanox.com header.b="o0hYwfnx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbfLKW5S (ORCPT ); Wed, 11 Dec 2019 17:57:18 -0500 Received: from mail-eopbgr20065.outbound.protection.outlook.com ([40.107.2.65]:21258 "EHLO EUR02-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726141AbfLKW5S (ORCPT ); Wed, 11 Dec 2019 17:57:18 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fbI8FjhSUl1AUlfrYj6SSubl8UFPoaGfDy7xfnUvKjZauRhUZvMIRFE4/qOSE5OAmplZemcsQvn2Ld54Y2d3psEaMkyZXfGe7X1SLJJaZHpTI2rQrwoPu82IjxD7yNuz8lAINPMSwVKCjn+h0bpjRQTdSuFcZjmK3Ss55vjFj7DL/fzQ9HNdVxrPWCTcRxILgkJe6QERdp0G1XxBttMXuy9CvaAJGmGgLm/rfYAitxvhvNZLtOTDIE5NqsRuMCRubu130Av61C/Cm1cGbQuVmGVulZ4NVtow/RjJWro28oTnh4b/M34mVTR0LCWd2S3yQq2BjR2T5y0Nh5UrOkIdJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JSCeP37ZJyxEfjg2snOSnM6nokCTo9q9SIJAZ9QCJ4=; b=b3JspRaquwFZ8CzLAOUOP39qzpz6AOVI2MjlUdksvBHEane/c5uK+eXbnD6iZO6b3AJ7PoOmhgIoZZukCXhcLoLEjt0touNXeWhRNJTOUsfya2NaUWK0LLA1KsNKDeDHBl+GoGUJ6l49P/Ew4vDxviA2gB9Sd394qWDGCiVVbwz7PRVL7wa98i5mv7q+r7c34qnEp7cpHoaAU7+SI3TKjsMVUgf6okEORS4ZihzT5xcaiAaDBaSMO6iouh6jd+qInk9GP2SLpfO/atSFqDk+wCeOPy1EVl7fInKhY+Boqgytqp1mK8i3jJ2FVyfuwIdtd6gUgHWulDG3RwXlgGhkQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8JSCeP37ZJyxEfjg2snOSnM6nokCTo9q9SIJAZ9QCJ4=; b=o0hYwfnxTaZy0UoAwsSi0HIg+at9jaqmRbX1xwpo+nLpLgLjnPabEwpTtcDy05X/SCvfdNO6luZlHAKy0w4pDIOBzEgOt5FlOdP98WVbMnyK/lDw3aFlh3rgEb3kJkwSqNGx0hoxurJbNRQCemuT2KDBD5555HQxBmTOgNPFm/A= Received: from DB7PR05MB4138.eurprd05.prod.outlook.com (52.135.129.16) by DB7PR05MB4908.eurprd05.prod.outlook.com (20.176.233.205) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2538.15; Wed, 11 Dec 2019 22:57:13 +0000 Received: from DB7PR05MB4138.eurprd05.prod.outlook.com ([fe80::f9f4:95d6:71ab:7003]) by DB7PR05MB4138.eurprd05.prod.outlook.com ([fe80::f9f4:95d6:71ab:7003%5]) with mapi id 15.20.2516.018; Wed, 11 Dec 2019 22:57:13 +0000 From: Jason Gunthorpe To: Jerome Glisse CC: Linus Torvalds , Ralph Campbell , David Airlie , "Kuehling, Felix" , "dri-devel@lists.freedesktop.org" , Christoph Hellwig , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , Andrew Morton , Dan Williams , "linux-rdma@vger.kernel.org" Subject: Re: [GIT PULL] Please pull hmm changes Thread-Topic: [GIT PULL] Please pull hmm changes Thread-Index: AQHVo9Dog/MtwM8aJU6I/7345tJKuKekCWkAgAAFfoCAA6/3AIAEBIsAgAnhkIA= Date: Wed, 11 Dec 2019 22:57:13 +0000 Message-ID: <20191211225703.GE3434@mellanox.com> References: <20191125204248.GA2485@ziepe.ca> <20191203024206.GC5795@mellanox.com> <20191205160324.GB5819@redhat.com> In-Reply-To: <20191205160324.GB5819@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SN4PR0501CA0019.namprd05.prod.outlook.com (2603:10b6:803:40::32) To DB7PR05MB4138.eurprd05.prod.outlook.com (2603:10a6:5:23::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=jgg@mellanox.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [217.140.111.136] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 2fbf81f5-a5ea-4237-c645-08d77e8d7644 x-ms-traffictypediagnostic: DB7PR05MB4908: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 024847EE92 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(4636009)(346002)(366004)(396003)(376002)(39860400002)(136003)(189003)(199004)(54906003)(4326008)(478600001)(6916009)(6506007)(2616005)(2906002)(5660300002)(1076003)(8936002)(66476007)(86362001)(6512007)(66946007)(8676002)(81166006)(7416002)(66556008)(36756003)(186003)(52116002)(81156014)(33656002)(64756008)(66446008)(6486002)(26005)(71200400001)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:DB7PR05MB4908;H:DB7PR05MB4138.eurprd05.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WNJVRO42MBAZa2BuOnnkcmtX1DyIJW7lLW/kAOIH70oJ+QaW8QTPTWMiMlllDzKIi7hWbJ4lgeef9VTD59fGurIB/B4sBO0EGlV9yXFnJbKwcWyab2zG+NvH/Umi1pYgrJLb5hB7Rot63BAynGm/9naJOQRkN9Nu54YHwZgaU4I+BddphW8zQ+YPWLgGkjc9cq/l6ewCXFzMbpaA1WkX82eF7wqkzKxzAvJ4RVs8yj4MRFY+WEZftSR7N3vKjd5X16Qkl9w79xkHNy4LM8AuGY2hNtxj3enwMmv8kgU89H0HkU0ycTpAvP9u1DR0SLVa3C9HGvO0Attbp32TYLFJC29UGvGhXEeQnBChIs836el1M2zhtGxZVZZ7SQZLrdJQjYGyYbrEJw1pMLK7AUVBnWAbTLekJPuwozubPoxb92G/euROO9LYLfJFaeOJhv2V x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-ID: <7D48963BDE69684698F1C710FEB0EADA@eurprd05.prod.outlook.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2fbf81f5-a5ea-4237-c645-08d77e8d7644 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Dec 2019 22:57:13.7960 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Fn2wH02dOCkojCc2nR39rClE8tellR3RczxSTIRTVzoDG+yz86Z3NRg/a7OWwmAgBkrnFhI9CJvVvdYHcivOMw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB7PR05MB4908 Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Dec 05, 2019 at 11:03:24AM -0500, Jerome Glisse wrote: > > struct mmu_notifier_mm (ie the mm->mmu_notifier_mm) > > -> mmn_mm > > struct mm_struct=20 > > -> mm > > struct mmu_notifier (ie the user subscription to the mm_struct) > > -> mn > > struct mmu_interval_notifier (the other kind of user subscription) > > -> mni >=20 > What about "interval" the context should already tell people > it is related to mmu notifier and thus a notifier. I would > just remove the notifier suffix, this would match the below > range. Interval could be a good replacement for mni in the mm/mmu_notififer file if we don't do the wholesale rename > > I think it would be overall nicer with better names for the original > > structs. Perhaps: > >=20 > > mmn_* - MMU notifier prefix > > mmn_state <- struct mmu_notifier_mm > > mmn_subscription (mmn_sub) <- struct mmu_notifier > > mmn_range_subscription (mmn_range_sub) <- struct mmu_interval_notifier > > mmn_invalidate_desc <- struct mmu_notifier_range >=20 > This looks good. Well, lets just bite the bullet then and switch it. Do you like 'state'? I thought that was the weakest one We could use mmnotif as the prefix, this makes the longest: struct mmnotif_range_subscription Which is reasonable enough > Maybe we can do a semantic patch to do convertion and then Linus > can easily apply the patch by just re-running the coccinelle. I tried this last time I renamed everything, it was OK, but it missed updating the comments. So it still needs some by-hand helping. I'll make some patches next week when I get back. Jason