From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3DCCC33CAF for ; Thu, 16 Jan 2020 18:41:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8F76F2077B for ; Thu, 16 Jan 2020 18:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579200068; bh=9CDhK2Sd42pZ+PhVJnnuGEpUks1p1zRL9gxcUm+9XKo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=sZxx2MXErea1SNz81AaaHXQmUmc3wpsCRwZZTwfXA1Gmfs5rIDBX/GlD1PDHzCF41 LLES93ibgU15giYbp1J2b9XnHebqv9O3v7tEPIbQah138cHxyq2S1ldxybOU6VtoPe +pfocfAEnU6NHrxCKAzY+1uUpgGjrMunw4MEIfO8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390446AbgAPSlD (ORCPT ); Thu, 16 Jan 2020 13:41:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:53516 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389358AbgAPRLx (ORCPT ); Thu, 16 Jan 2020 12:11:53 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 767D824692; Thu, 16 Jan 2020 17:11:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579194713; bh=9CDhK2Sd42pZ+PhVJnnuGEpUks1p1zRL9gxcUm+9XKo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t6cEFPn87+n2PhdBSnuuwAcwfVHCu0JhrizWUFUX/TnU1RTqu9OtjrD+ZrFlx7kFz LYsvDJsBEufSZcb7o/JMFYAwkVzC+J9G54Wu8XdQaHS3/Y+nF7BHHEf0iUg+kWWTAV k3U/JlXDLfmpB8vfgQCoG9d8rbPETdElKv8ddTjI= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Navid Emamdoost , Jason Gunthorpe , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 550/671] RDMA: Fix goto target to release the allocated memory Date: Thu, 16 Jan 2020 12:03:08 -0500 Message-Id: <20200116170509.12787-287-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200116170509.12787-1-sashal@kernel.org> References: <20200116170509.12787-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org From: Navid Emamdoost [ Upstream commit 4a9d46a9fe14401f21df69cea97c62396d5fb053 ] In bnxt_re_create_srq(), when ib_copy_to_udata() fails allocated memory should be released by goto fail. Fixes: 37cb11acf1f7 ("RDMA/bnxt_re: Add SRQ support for Broadcom adapters") Link: https://lore.kernel.org/r/20190910222120.16517-1-navid.emamdoost@gmail.com Signed-off-by: Navid Emamdoost Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe Signed-off-by: Sasha Levin --- drivers/infiniband/hw/bnxt_re/ib_verbs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/bnxt_re/ib_verbs.c b/drivers/infiniband/hw/bnxt_re/ib_verbs.c index bea8318e7007..a019ff266f52 100644 --- a/drivers/infiniband/hw/bnxt_re/ib_verbs.c +++ b/drivers/infiniband/hw/bnxt_re/ib_verbs.c @@ -1446,7 +1446,7 @@ struct ib_srq *bnxt_re_create_srq(struct ib_pd *ib_pd, dev_err(rdev_to_dev(rdev), "SRQ copy to udata failed!"); bnxt_qplib_destroy_srq(&rdev->qplib_res, &srq->qplib_srq); - goto exit; + goto fail; } } if (nq) -- 2.20.1