From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=l8MA=3L=vger.kernel.org=linux-rdma-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 25B99C2D0DB
	for <linux-rdma@archiver.kernel.org>; Wed, 22 Jan 2020 15:45:31 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id EBAC8217F4
	for <linux-rdma@archiver.kernel.org>; Wed, 22 Jan 2020 15:45:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
	s=default; t=1579707931;
	bh=fiFliyvTvD4+vKGaEmROxrWcVL8c+wPaQxTR+JOqqxw=;
	h=Date:From:To:Cc:Subject:In-Reply-To:References:List-ID:From;
	b=zHUCGi+Ayj6lDfyM8DRY3c1AcYF1J47e02jr5uIuwqy6HB1WI511r4b0xccIEOhy/
	 jGJxgzM5wbVYC7S2aJ/G7EES+lAvy2AKWrrZNlRjQ64xV8U9stydS+p9lOyPl3YJe+
	 iTiJd6W3b3vg+YCcMAlHxRVY9NJ5hzEwVTQ+4Bms=
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1725924AbgAVPpa (ORCPT <rfc822;linux-rdma@archiver.kernel.org>);
        Wed, 22 Jan 2020 10:45:30 -0500
Received: from mail.kernel.org ([198.145.29.99]:38328 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1725836AbgAVPpa (ORCPT <rfc822;linux-rdma@vger.kernel.org>);
        Wed, 22 Jan 2020 10:45:30 -0500
Received: from cakuba (c-73-93-4-247.hsd1.ca.comcast.net [73.93.4.247])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id 4BC09217F4;
        Wed, 22 Jan 2020 15:45:29 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1579707929;
        bh=fiFliyvTvD4+vKGaEmROxrWcVL8c+wPaQxTR+JOqqxw=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=TrrB8Q/apTjmtijw9B8YJjMMFfc+MFwXwn+v0skUaTVk4soAlpGjGbRiS6m/xZVom
         i0nTnpPxWHgCiuoqQhMTABWS63jEgn9RfL3ZCRSXee2Rt8+hHgrHOrpygoUhnx3/Qj
         1zN9V0WQCF8KFsoy62fZnf+wpr+OWBTwuQ6h81+M=
Date:   Wed, 22 Jan 2020 07:45:28 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Michal Kalderon <michal.kalderon@marvell.com>
Cc:     <ariel.elior@marvell.com>, <davem@davemloft.net>,
        <netdev@vger.kernel.org>, <linux-rdma@vger.kernel.org>,
        <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH net-next 01/14] qed: FW 8.42.2.0 Internal ram offsets
 modifications
Message-ID: <20200122074528.670d3d2a@cakuba>
In-Reply-To: <20200122152627.14903-2-michal.kalderon@marvell.com>
References: <20200122152627.14903-1-michal.kalderon@marvell.com>
        <20200122152627.14903-2-michal.kalderon@marvell.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-rdma-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-rdma.vger.kernel.org>
X-Mailing-List: linux-rdma@vger.kernel.org

On Wed, 22 Jan 2020 17:26:14 +0200, Michal Kalderon wrote:
> IRO stands for internal RAM offsets. Updating the FW binary produces
> different iro offsets. This file contains the different values,
> and a new representation of the values.
> 
> Signed-off-by: Ariel Elior <ariel.elior@marvell.com>
> Signed-off-by: Michal Kalderon <michal.kalderon@marvell.com>

If you have different offsets depending on FW build - where is the code
that checks the FW version is the one driver expects? At a quick glance
you're not bumping any numbers in this patch..