From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56554C35242 for ; Fri, 24 Jan 2020 02:52:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 248052467B for ; Fri, 24 Jan 2020 02:52:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="JFRg77kC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730177AbgAXCwY (ORCPT ); Thu, 23 Jan 2020 21:52:24 -0500 Received: from mail-pj1-f67.google.com ([209.85.216.67]:34779 "EHLO mail-pj1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730355AbgAXCwY (ORCPT ); Thu, 23 Jan 2020 21:52:24 -0500 Received: by mail-pj1-f67.google.com with SMTP id f2so217137pjq.1 for ; Thu, 23 Jan 2020 18:52:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+Jtje9PzdEFeKTXOcqQTD8adTbqITK8jdsG/R2A7AX8=; b=JFRg77kCHY7BV5hfbYDprPhohNPs2OasesHM0M5Htda7XBUsY4XcUNquAXDlwSzMdd u/uSwCEgyJcbrUnZ2n0jBbtr2qFg0BUlZQh95U/iqPHxqf+RZ27Kh0nn1zsvHbdl/B5t qBmGDZQaCO9O0wVcBWvt34bGvY/O4vZ2rlyMF4t2WmjT5wtUwrLAtF3X4ye0C8NgxpQd ZkNH8Cvu3UjCCBl2h94e2aNiFhBW5jXGeonrXlshNGwRu3WR/Otb8PnMHSnGvN5hqiUk Zxre/fjgiBqEQaaow4koVxgu/zlhlcBk4LwnyOlvlL8dJmCNDR2JHhGeMLq/YLFZuVGF n7XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+Jtje9PzdEFeKTXOcqQTD8adTbqITK8jdsG/R2A7AX8=; b=YM9CG4UwtQk5OdL8E+3RdM4SkQn7SOjcgNPMb08BrWnWFpFcqgvoIFISoB0Lqz28/I zbzQJH+KTAleaQ6eIzTEkoKosGTda0pd8tTtPbbCNiFnBwyJPU+d1CW12G4Nxlc9ItWf F17+WTXMCaywbEmoX3BHMJkbrtTlQJXCf9u0GOrJewkNV5atGGI5yRXYBs78mJZ/DInD YRJpBVPY2Wql0Yf309cGU6kw4kSTdJr+oxJtCmyksxgMQ2qAB7xpSM0Dnh6oZigv0sOg t/Yoslw9a9SiGNOE2VHwpuA/1dq5PSiJnnOtOIA7yd6jh4e8/FxOfqWiJbWNksrqH8M9 Zdog== X-Gm-Message-State: APjAAAUYx3SqofsW2qVJzmah2vkzguq+ekDkZ/vBe0W2UQ7K8vXyNsAD 9JZwuJTaw/SNvVCbTvyWRKffyg== X-Google-Smtp-Source: APXvYqzWQ2DtSK2CwiuWk6fQuD8WmyvfPzVBXvCYBm2swLW8wy6vd/uPMq/EqmZRVV6NZU9oGOuJEQ== X-Received: by 2002:a17:90a:c389:: with SMTP id h9mr910062pjt.128.1579834343395; Thu, 23 Jan 2020 18:52:23 -0800 (PST) Received: from ziepe.ca ([216.9.110.1]) by smtp.gmail.com with ESMTPSA id i127sm4094711pfe.54.2020.01.23.18.52.22 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 23 Jan 2020 18:52:22 -0800 (PST) Received: from jgg by jggl.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1iup53-0004Hr-BB; Thu, 23 Jan 2020 22:52:21 -0400 Date: Thu, 23 Jan 2020 22:52:21 -0400 From: Jason Gunthorpe To: "Saleem, Shiraz" Cc: Gal Pressman , Leon Romanovsky , Doug Ledford , "linux-rdma@vger.kernel.org" , Alexander Matushevsky , "stable@vger.kernel.org" , "Leybovich, Yossi" Subject: Re: [PATCH for-rc] Revert "RDMA/efa: Use API to get contiguous memory blocks aligned to device supported page size" Message-ID: <20200124025221.GA16405@ziepe.ca> References: <20200120141001.63544-1-galpress@amazon.com> <0557a917-b6ad-1be7-e46b-cbe08f2ee4d3@amazon.com> <20200121162436.GL51881@unreal> <47c20471-2251-b93b-053d-87880fa0edf5@amazon.com> <20200123142443.GN7018@unreal> <60d8c528-1088-df8d-76f0-4746acfcfc7a@amazon.com> <9DD61F30A802C4429A01CA4200E302A7C57244BB@fmsmsx123.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9DD61F30A802C4429A01CA4200E302A7C57244BB@fmsmsx123.amr.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Jan 24, 2020 at 12:40:18AM +0000, Saleem, Shiraz wrote: > It would be good to get the debug data to back this or prove it wrong. > But if this is indeed what's happening, then ORing in the sgl->length for the > first sge to restrict the page size might cut it. So something like, or'ing in the sgl length is a nonsense thing to do, the length has nothing to do with the restriction, which is entirely based on IOVA bits which can't be passed through. Jason