archive mirror
 help / color / mirror / Atom feed
From: David Miller <>
Subject: Re: [PATCH net-next v4] net/core: Replace driver version to be kernel version
Date: Mon, 27 Jan 2020 13:47:48 +0100 (CET)	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

From: Leon Romanovsky <>
Date: Mon, 27 Jan 2020 09:20:28 +0200

> From: Leon Romanovsky <>
> In order to stop useless driver version bumps and unify output
> presented by ethtool -i, let's set default version string.
> As Linus said in [1]: "Things are supposed to be backwards and
> forwards compatible, because we don't accept breakage in user
> space anyway. So versioning is pointless, and only causes
> problems."
> They cause problems when users start to see version changes
> and expect specific set of features which will be different
> for stable@, vanilla and distribution kernels.
> Distribution kernels are based on some kernel version with extra
> patches on top, for example, in RedHat world this "extra" is a lot
> and for them your driver version say nothing. Users who run vanilla
> kernels won't use driver version information too, because running
> such kernels requires knowledge and understanding.
> Another set of problems are related to difference in versioning scheme
> and such doesn't allow to write meaningful automation which will work
> sanely on all ethtool capable devices.
> Before this change:
> [leonro@erver ~]$ ethtool -i eth0
> driver: virtio_net
> version: 1.0.0
> After this change and once ->version assignment will be deleted
> from virtio_net:
> [leonro@server ~]$ ethtool -i eth0
> driver: virtio_net
> version: 5.5.0-rc6+
> Link:
> Link:
> Link:
> Signed-off-by: Leon Romanovsky <>

Applied to net-next, thanks.

  parent reply	other threads:[~2020-01-27 12:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-27  7:20 Leon Romanovsky
2020-01-27  8:32 ` Shannon Nelson
2020-01-27 12:47 ` David Miller [this message]
2020-01-27 17:43 ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH net-next v4] net/core: Replace driver version to be kernel version' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).