From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 823BEC3B1A1 for ; Fri, 14 Feb 2020 16:45:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 587672187F for ; Fri, 14 Feb 2020 16:45:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="oNniTQAW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392972AbgBNQp4 (ORCPT ); Fri, 14 Feb 2020 11:45:56 -0500 Received: from mail-qv1-f68.google.com ([209.85.219.68]:47084 "EHLO mail-qv1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393872AbgBNQpz (ORCPT ); Fri, 14 Feb 2020 11:45:55 -0500 Received: by mail-qv1-f68.google.com with SMTP id y2so4535349qvu.13 for ; Fri, 14 Feb 2020 08:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=6zMAV6opT8F4IR1EmzI6ROBaFFltfgM895kUaotRIlk=; b=oNniTQAWE+1pH7ooqR0szPphGeNMfhxh0K7p07S3hqK3YV8+Aes8Eb32kL0g+XbGCQ tZTSWIurEjn2VjNJGS4dkuitS7jaRUJlDOsRFMYf+yZvusk2yC2vRxp6+SUha9lbwLPj K/aiKYG445wnrz7BD+AJh6emWHCrnd2TqN4I8bFP5Pu4jARATLSwVNU0n9it+fGx/+Wo i4H2rDyDIV3e2v9AybQXyYP5BJ6EXFhmupT8MQ+b1Vn4geVLh9xESJEVmDd3DnBR9xMr pY7nAEPWnZ3hinT0yhPJa5O9MlrNoTqAwJYANNJsqpQzuYYawT26BlUjYviy8Rxzpegj KVuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=6zMAV6opT8F4IR1EmzI6ROBaFFltfgM895kUaotRIlk=; b=sNKeRqX9wQyeDlo6KrA4/ptanSWBb9pgwYKt3Zf1zcr/cER9U2MRtUIzAf84DEqE28 US2gcGNxTuvRhw7PdM/Ocpu3jixbHidZTG6JqCRReorAMupgY06LUjmZLQVzI18Cwpd7 EGzXgl/qfEQ/HgWPkGiKyiX1wCUkuKMoteYGBks9GY9VtR6xwA1H4AbYKyX+HhwRoAgS 1KOvReSxlG04O9GWQiJgGzqgfA/7F7aBlNinM6JlgnrImE+hMbSMndqAyP4VdHX7Sa2q YHDuQHqotwedq4j1eeZ8pTt6tqlAvlpp9CL52+btpoxLV8o/ddqSzOpMMOU4jsu1vNCQ S7cQ== X-Gm-Message-State: APjAAAV+j242fiiH8COu1BPpzisWuGfOR8JTqjy/8FCKtG2j1xhtKIH8 SPI3ovrIPkn5qAnW0FnWpjWowA== X-Google-Smtp-Source: APXvYqwyqbVW2l3NU+TGVwqM1Q2R64Pbxb1BEV1d5U3mEZkqfT6cMit9OEAbxJF0vAUFwm5AzEvPfQ== X-Received: by 2002:a0c:fe8d:: with SMTP id d13mr2983695qvs.217.1581698754942; Fri, 14 Feb 2020 08:45:54 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id d20sm1734570qkg.8.2020.02.14.08.45.54 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 14 Feb 2020 08:45:54 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j2e6D-0001DP-RH; Fri, 14 Feb 2020 12:45:53 -0400 Date: Fri, 14 Feb 2020 12:45:53 -0400 From: Jason Gunthorpe To: Andrew Boyer Cc: Jeff Kirsher , davem@davemloft.net, gregkh@linuxfoundation.org, Mustafa Ismail , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, Shiraz Saleem Subject: Re: [RFC PATCH v4 18/25] RDMA/irdma: Implement device supported verb APIs Message-ID: <20200214164553.GV31668@ziepe.ca> References: <20200212191424.1715577-1-jeffrey.t.kirsher@intel.com> <20200212191424.1715577-19-jeffrey.t.kirsher@intel.com> <20200214145443.GU31668@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Fri, Feb 14, 2020 at 10:49:38AM -0500, Andrew Boyer wrote: > > > On Feb 14, 2020, at 9:54 AM, Jason Gunthorpe wrote: > > > > On Wed, Feb 12, 2020 at 11:14:17AM -0800, Jeff Kirsher wrote: > > ... > > New drivers are forbidden from calling this: > > > > /** > > * rdma_set_device_sysfs_group - Set device attributes group to have > > * driver specific sysfs entries at > > * for infiniband class. > > * > > * @device: device pointer for which attributes to be created > > * @group: Pointer to group which should be added when device > > * is registered with sysfs. > > * rdma_set_device_sysfs_group() allows existing drivers to expose one > > * group per device to have sysfs attributes. > > * > > * NOTE: New drivers should not make use of this API; instead new device > > * parameter should be exposed via netlink command. This API and mechanism > > * exist only for existing drivers. > > */ > > > > Jason > > Is there an existing field in RDMA_NLDEV_ATTR_* that allows us to > display a string to use as a replacement for the board_id in sysfs? I don't think so, this is highly vendor specific stuff. > Like “Mellanox ConnectX-3” or similar. General names like that can come from the pci database that udev and lspci keeps. Ie if you do 'systemctl -a' on a modern system with rdma-core you will see the PCI device description show up next to the verbs char device. > The other two sysfs fields (hca_type and hw_rev) seem to have been unused. I wonder if hw_rev was supposed to be the same as hw_ver (see ib_uverbs_query_device_resp). Jason