From: Jason Gunthorpe <jgg@mellanox.com>
To: Max Gurtovoy <maxg@mellanox.com>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA/core: Get rid of ib_create_qp_user
Date: Wed, 19 Feb 2020 00:35:38 +0000 [thread overview]
Message-ID: <20200219003534.GE23930@mellanox.com> (raw)
In-Reply-To: <acbaf760-a3fe-f3c6-4b0b-e3e9a48cc876@mellanox.com>
On Sun, Feb 16, 2020 at 01:44:40PM +0200, Max Gurtovoy wrote:
>
> On 2/13/2020 9:19 PM, Jason Gunthorpe wrote:
> > This function accepts a udata but does nothing with it, and is never
> > passed a !NULL udata. Rename it to ib_create_qp which was the only
> > caller and remove the udata.
> >
> > Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
>
> Looks good,
>
> Reviewed-by: Max Gurtovoy <maxg@mellanox.com>
Thanks, and applied to for-next
> BTW,
>
> shouldn't ib_alloc_mr_user need also to be updated ?
How so? It passes the udata to the driver
Jason
prev parent reply other threads:[~2020-02-19 0:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 19:19 [PATCH] RDMA/core: Get rid of ib_create_qp_user Jason Gunthorpe
2020-02-16 11:44 ` Max Gurtovoy
2020-02-19 0:35 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219003534.GE23930@mellanox.com \
--to=jgg@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=maxg@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).