From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8C7EC34056 for ; Wed, 19 Feb 2020 17:55:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AD66B24656 for ; Wed, 19 Feb 2020 17:55:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="W35GK9Ws" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726582AbgBSRzb (ORCPT ); Wed, 19 Feb 2020 12:55:31 -0500 Received: from mail-qt1-f195.google.com ([209.85.160.195]:36918 "EHLO mail-qt1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726514AbgBSRza (ORCPT ); Wed, 19 Feb 2020 12:55:30 -0500 Received: by mail-qt1-f195.google.com with SMTP id w47so855176qtk.4 for ; Wed, 19 Feb 2020 09:55:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3OWvKNSFK5+1jzkc9ih7irkJXb1MleGfxd/g4bwizqM=; b=W35GK9WsDfntYhq4PMhnP2+gBuPXVOLCKW/ad4UqMk2DwklrF6vx/PwpAfX3kpAjCd gZwTa/+md8nZfM3C0UIhoNSBuQ0KPtUK5xlPg3DM3267NE5NUKjRyCsjtiZMgouHyIXD AzmBcG54LMlloTuNHyRhtcaEUcyidiWdOR+VOoj/MmYlxucDGrRwoJn/DhqBh+nkYROj GkYLbpep+ZsEPgg7hljM0sxhDeJp+4d0VdfrrBr/oXoBM7lLRxRPqLTPU7N1Fv5LT2ZN vsCQ2bwdpPq5dDPc9T270KWlx+AuA9iDL9jmSn1IR74c+dWIIQ8zbgPLkZaHZrkt5jLA xunA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3OWvKNSFK5+1jzkc9ih7irkJXb1MleGfxd/g4bwizqM=; b=uW26vLRdgSrDE3SnAWBdrBJlQUJ3p6N3sk0/mnFuVcXTE5iloZe21U7VsfT+5OrddE gb0RmxwCCYxC9hvDXPM8O/hKz2lHqBbgVRtMz4YmJMYJzZG5AMdfXqy8u7ujYIrSGMeB fcZy/Fm26hqwOWqim8otsuAWKHCIe1PMaDLslggeGNY+gn99LDWi1MafGwWR0N6ctB0o f+q9Yn/VKJt1hL8rO/JIgOLFkVXpgg8t17yfPCS41kQw9RVhwFQQANkBNbsGAWohLahu VIeATHeUq3fjAzbUI+NpYFp+klETnnOWVRIsht047aGMpMej9ShznebgNIQsf4H8BxSX /SIQ== X-Gm-Message-State: APjAAAW9AUwBx6Jfu0qe4j572MOtNcKegOaLC/o/qAMg/rLmD1Hnjlcy l1CXBs7ulV4ppnqeDdSkkeBWsfWBhtqfTQ== X-Google-Smtp-Source: APXvYqxKTLKRN/BVe0j86S1DCTEgP8QL4hMX3or2M/J9e+Yc9rdjBTfSG00fuT5G35r6YoURPK2P9A== X-Received: by 2002:ac8:1196:: with SMTP id d22mr23206829qtj.344.1582134929923; Wed, 19 Feb 2020 09:55:29 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id j11sm198098qkl.97.2020.02.19.09.55.29 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 19 Feb 2020 09:55:29 -0800 (PST) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1j4TZI-0003wy-Up; Wed, 19 Feb 2020 13:55:28 -0400 Date: Wed, 19 Feb 2020 13:55:28 -0400 From: Jason Gunthorpe To: Tom Talpey Cc: Mark Zhang , Alex Rosenbaum , RDMA mailing list , Eran Ben Elisha , Yishai Hadas , Alex Rosenbaum , Maor Gottlieb , Leon Romanovsky Subject: Re: [RFC v2] RoCE v2.0 Entropy - IPv6 Flow Label and UDP Source Port Message-ID: <20200219175528.GU31668@ziepe.ca> References: <20200213154110.GJ31668@ziepe.ca> <3be3b3ff-a901-b716-827a-6b1019fa1924@mellanox.com> <55e8c9cf-cd64-27b2-1333-ac4849f5e3ff@talpey.com> <4fc5590f-727c-2395-7de0-afb1d83f546b@mellanox.com> <91155305-10f0-22b5-b93b-2953c53dfc46@talpey.com> <20200219130613.GM31668@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Feb 19, 2020 at 12:41:53PM -0500, Tom Talpey wrote: > On 2/19/2020 8:06 AM, Jason Gunthorpe wrote: > > On Wed, Feb 19, 2020 at 02:06:28AM +0000, Mark Zhang wrote: > > > The symmetry is important when calculate flow_label with DstQPn/SrcQPn > > > for non-RDMA CM Service ID (check the first mail), so that the server > > > and client will have same flow_label and udp_sport. But looks like it is > > > not important in this case. > > > > If the application needs a certain flow label it should not rely on > > auto-generation, IMHO. > > > > I expect most networks will not be reversible anyhow, even with the > > same flow label? > > These are network flow labels, not under application control. If they > are under application control, that's a security issue. Eh? ipv6 puts them under application control. Jason