From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C96AC43331 for ; Thu, 26 Mar 2020 18:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E5C0420714 for ; Thu, 26 Mar 2020 18:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="DKUX1BHk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgCZSHF (ORCPT ); Thu, 26 Mar 2020 14:07:05 -0400 Received: from mail-qv1-f67.google.com ([209.85.219.67]:33991 "EHLO mail-qv1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726163AbgCZSHF (ORCPT ); Thu, 26 Mar 2020 14:07:05 -0400 Received: by mail-qv1-f67.google.com with SMTP id o18so3528028qvf.1 for ; Thu, 26 Mar 2020 11:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=8blfNKcDeoBIPufjTFZsklBm/0Dor9f8ZVJaWR3UrK8=; b=DKUX1BHk06ERJh37xYHb/jP5oKcKpIiiWkKxSM4+Wt0c456Dfl5tzDVsEqk7jx5DUA OfKMJNUR1TtyFSfq8mmICmCGU3LRPPJCaHY/ANeBElf0olb0V63JVX6Tmj6WJbVpDVBi XJp0BYOtBj8v/bAemow3Lx3Od8VCHCKNFNW8wUhaYiaKxV5I06PPH+49OJXN1xNoKLn6 /JQnJGBEBxNBGF7b2pS1oDApysM4NrLdJvlMiVWsIT3VxCVZ1isOoOju1yzohDMDlcCt YO8Cc84vaWXLgkYRpem3h5o3uR1dKOdwTYtAn5gE59E6h4WSKBgVkaWcmpVla+zsSARm nbqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=8blfNKcDeoBIPufjTFZsklBm/0Dor9f8ZVJaWR3UrK8=; b=dFeoynflZlXf+Jcf2Okh51DMLlxfKycrJ4z420rDBfDRpcziQDncAt5sj1TBdv6f92 O0orzGf0FvkxUEYHdG409YUP6GqjpnATer+xsCtuOLvn4jgejN14SX3oHZzFY4EmeHZT OQS6ndAJydF5McMxtE0Ror3q+srjPWbqRZKy3yMFXvkaIPbaPMpp+mrulGkNFGbrSLec ITAuzN++vUkdQ3KBli94AHmTjx188zePyCMfVsqyrt7Tibyl7HxdtEONDSTCKez1Ebs0 SlKxd00GuWDdUGFUnW41NKtGxvJp264/doMMrHk9JcFZXzVzgOHiQROms4dWhR6988+p QUhA== X-Gm-Message-State: ANhLgQ0Qgq43GsQw/f/2FXs5Ivs86fIF5QseT0ve2S9N5GQjne5frNqN nr0ZuflLXLRWGyeWnTOw28Wu4Q== X-Google-Smtp-Source: ADFU+vvi09yZFDxKdrNic5iQNWICdw4JgkAgWBCUWoeItEYtkI1mOy3qoP1EGWX8cOeu7dngrT8qdg== X-Received: by 2002:a0c:a998:: with SMTP id a24mr9425908qvb.141.1585246023828; Thu, 26 Mar 2020 11:07:03 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-142-68-57-212.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.57.212]) by smtp.gmail.com with ESMTPSA id b189sm1848209qkc.104.2020.03.26.11.06.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 26 Mar 2020 11:06:57 -0700 (PDT) Received: from jgg by mlx.ziepe.ca with local (Exim 4.90_1) (envelope-from ) id 1jHWu7-00048x-Q3; Thu, 26 Mar 2020 15:06:55 -0300 Date: Thu, 26 Mar 2020 15:06:55 -0300 From: Jason Gunthorpe To: Takashi Iwai Cc: linux-rdma@vger.kernel.org, Mike Marciniszyn , Dennis Dalessandro , Doug Ledford Subject: Re: [PATCH] infiniband: hfi1: Use scnprintf() for avoiding potential buffer overflow Message-ID: <20200326180655.GA15899@ziepe.ca> References: <20200319154641.23711-1-tiwai@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200319154641.23711-1-tiwai@suse.de> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Thu, Mar 19, 2020 at 04:46:41PM +0100, Takashi Iwai wrote: > Since snprintf() returns the would-be-output size instead of the > actual output size, the succeeding calls may go beyond the given > buffer limit. Fix it by replacing with scnprintf(). > > Cc: Mike Marciniszyn > Cc: Dennis Dalessandro > Cc: Doug Ledford > Cc: Jason Gunthorpe > Cc: linux-rdma@vger.kernel.org > Signed-off-by: Takashi Iwai > --- > drivers/infiniband/hw/hfi1/fault.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to for-next, thanks Jason